Skip to content

Commit

Permalink
Remove the ratelimiting exception. Prefer safety over speed
Browse files Browse the repository at this point in the history
We need to check the performance ramifications of this during
testing, but considering that we will almost certainly be iterating
over hundreds of users, we should probably let k8s itself rate
limit us so we don't overwhelm whatever is running the control
plane. That might otherwise be a nasty situation, especially for
stuff like AKS and GKE.
  • Loading branch information
nflynt committed Aug 9, 2023
1 parent 16715df commit a60b144
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions pkg/agent/clean/active_directory.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ import (
"github.com/rancher/rancher/pkg/auth/providers/common/ldap"
v3client "github.com/rancher/rancher/pkg/client/generated/management/v3"
"github.com/rancher/rancher/pkg/types/config"
"github.com/rancher/wrangler/pkg/ratelimit"
"github.com/sirupsen/logrus"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/runtime"
Expand Down Expand Up @@ -268,7 +267,6 @@ func prepareClientContexts(clientConfig *restclient.Config) (*config.ScaledConte
return nil, nil, err
}
}
restConfig.RateLimiter = ratelimit.None

sc, err := scaledContext(restConfig)
if err != nil {
Expand Down

0 comments on commit a60b144

Please sign in to comment.