chore: Solve lint warnings #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Itzabelli is attempting to deploy a commit to the Yearn Finance Team on Vercel. A member of the Team first needs to authorize it. |
karelianpie
reviewed
Jul 28, 2023
apps/common/components/Header.tsx
Outdated
| @@ -92,7 +92,7 @@ function NetworkSelector({networks}: {networks: number[]}): ReactElement { | |||
| <div key={safeChainID} className={'relative z-50 mr-4'}> | |||
| <Listbox | |||
| value={safeChainID} | |||
| onChange={async (value: any): Promise<void> => onSwitchChain(value.value)}> | |||
| onChange={async (value: number): Promise<void> => onSwitchChain(value)}> | |||
There was a problem hiding this comment.
Unsure about this, it conflicts with https://github.com/yearn/yearn.fi/pull/304/files#diff-110219777e6710fd004b7cacde9e6da2a8eb9d9646ba582321aa88ebc90cdf9eR112
karelianpie
requested changes
Jul 28, 2023
There was a problem hiding this comment.
LGTM! Let's revert https://github.com/yearn/yearn.fi/pull/307/files#r1277122053 then we can merge
I reverse the replacement of the 'any' type to the 'number' type, because it conflicts with other changes.
karelianpie
approved these changes
Jul 28, 2023
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After ran
yarn lintthese errors and warnings are being recorded in the terminal.⛔ error Run autofix to sort these imports! simple-import-sort/imports.
The purpose of this PR is to fix them.
Extra: I removed the unnecessary react import.
Related Issue
N/A
Motivation and Context
The intent of these changes are to solve warnings listed above.
How Has This Been Tested?
After making the changes, I ran
yarn devand I ensured that everything appears as expected and I confirmed that the console is not registering the warningsScreenshots (if appropriate):
N/A