feat: Let users search for both the vault name and symbol #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
karelianpie
commented
Jul 21, 2023
Comment on lines
-219
to
-220
| const vaultsToUse = [...vaultsToDisplay]; | ||
|
|
There was a problem hiding this comment.
This seemed unnecessary, spreading the vaults to just put them back again into an array
Majorfi
approved these changes
Jul 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the vault symbol to compare against the
searchValueRelated Issue
Closes #291
Motivation and Context
Let users search for both the vault name and symbol so they are more likely to find the vault they are looking for.
How Has This Been Tested?
Tried locally, refer to the screenshot below
Screenshots (if appropriate):