Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update yCRV with v2 lp contract
TODO:
Done
0xdc899AB992fbCFbac936CE5a5bC5A86a5d35A66a
input_token
should never be same asoutput_token
input_token == lp-yCRVv1
then output_token must belp-yCRVv2
min_out
must be calculated by the UI usingzap.calc_expected_out() * (1 - some_allowable_slippage)
The above calculation is very important to prevent users from being sandwich attacked. Potentially may want an additional warning to user to send txn through a private mempool like Flashbots.
Valid Input Tokens
0xc5bDdf9843308380375a611c18B50Fb9341f502A
yveCRV-DAO0x9d409a0A012CFbA9B15F6D4B36Ac57A46966Ab9a
yvBOOST0xFCc5c47bE19d06BF83eB04298b026F81069ff65b
yCRV0x27B5739e22ad9033bcBf192059122d163b60349D
st-yCRV0x6E9455D109202b426169F0d8f01A3332DAE160f3
lp-yCRVv20x453D92C7d4263201C69aACfaf589Ed14202d83a4
yCRV-f v10x99f5aCc8EC2Da2BC0771c32814EFF52b712de1E5
yCRV-f v20xD533a949740bb3306d119CC777fa900bA034cd52
CRV0x62B9c7356A2Dc64a1969e19C23e4f579F9810Aa7
cvxCRV0xc97232527B62eFb0D8ed38CF3EA103A6CcA4037e
lp-yCRVv1Valid Output Tokens
0xFCc5c47bE19d06BF83eB04298b026F81069ff65b
yCRV0x27B5739e22ad9033bcBf192059122d163b60349D
st-yCRV0x6E9455D109202b426169F0d8f01A3332DAE160f3
lp-yCRVv2Related Issue
NA
Motivation and Context
Ask for yLockers team
How Has This Been Tested?
WIP
Screenshots (if appropriate):