Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add yCRV2 setup #276

Merged
merged 5 commits into from
Jul 13, 2023
Merged

feat: add yCRV2 setup #276

merged 5 commits into from
Jul 13, 2023

Conversation

Majorfi
Copy link
Collaborator

@Majorfi Majorfi commented Jul 11, 2023

Description

Update yCRV with v2 lp contract

TODO:

  • Ensure we have token logos
  • Ensure we have the migration flow

Done

  • Zap v3 deployed @ 0xdc899AB992fbCFbac936CE5a5bC5A86a5d35A66a
  • input_token should never be same as output_token
  • If input_token == lp-yCRVv1 then output_token must be lp-yCRVv2
  • min_out must be calculated by the UI using zap.calc_expected_out() * (1 - some_allowable_slippage)
    The above calculation is very important to prevent users from being sandwich attacked. Potentially may want an additional warning to user to send txn through a private mempool like Flashbots.
  • Banner message “lp-yCRV is not longer receiving CRV emissions. If you hold lp-yCRV, please migrate to lp-yCRVv2, which is now the primary liquidity yCRV source.”

Valid Input Tokens

  • 0xc5bDdf9843308380375a611c18B50Fb9341f502A yveCRV-DAO
  • 0x9d409a0A012CFbA9B15F6D4B36Ac57A46966Ab9a yvBOOST
  • 0xFCc5c47bE19d06BF83eB04298b026F81069ff65b yCRV
  • 0x27B5739e22ad9033bcBf192059122d163b60349D st-yCRV
  • 0x6E9455D109202b426169F0d8f01A3332DAE160f3 lp-yCRVv2
  • 0x453D92C7d4263201C69aACfaf589Ed14202d83a4 yCRV-f v1
  • 0x99f5aCc8EC2Da2BC0771c32814EFF52b712de1E5 yCRV-f v2
  • 0xD533a949740bb3306d119CC777fa900bA034cd52 CRV
  • 0x62B9c7356A2Dc64a1969e19C23e4f579F9810Aa7 cvxCRV
  • 0xc97232527B62eFb0D8ed38CF3EA103A6CcA4037e lp-yCRVv1

Valid Output Tokens

  • 0xFCc5c47bE19d06BF83eB04298b026F81069ff65b yCRV
  • 0x27B5739e22ad9033bcBf192059122d163b60349D st-yCRV
  • 0x6E9455D109202b426169F0d8f01A3332DAE160f3 lp-yCRVv2

Related Issue

NA

Motivation and Context

Ask for yLockers team

How Has This Been Tested?

WIP

Screenshots (if appropriate):

@Majorfi Majorfi added enhancement New feature or request wip labels Jul 11, 2023
@Majorfi Majorfi requested a review from karelianpie July 11, 2023 16:24
@vercel
Copy link

vercel bot commented Jul 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
yearnfi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 13, 2023 9:48am

@Majorfi Majorfi added this pull request to the merge queue Jul 13, 2023
Merged via the queue into main with commit 2541830 Jul 13, 2023
@Majorfi Majorfi deleted the feat/ycrv2 branch July 13, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Ready
Projects
Status: 🟢 Done
Development

Successfully merging this pull request may close these issues.

2 participants