fix: CSS and default reward token symbol #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
karelianpie
commented
May 18, 2023
| @@ -15,6 +15,7 @@ module.exports = { | |||
| 'indent': 'off', | |||
| '@typescript-eslint/indent': ['error', 'tab'], | |||
| 'no-multi-spaces': ['error', {ignoreEOLComments: false}], | |||
| 'no-mixed-spaces-and-tabs': 'error' | |||
| 'no-mixed-spaces-and-tabs': 'error', | |||
| 'react/jsx-max-props-per-line': 'off' | |||
There was a problem hiding this comment.
I don't like the rule of X number of props per line, if the prop name or value are smallish then it's more than fine to have them in the same line :)
karelianpie
commented
May 18, 2023
There was a problem hiding this comment.
DRYed a bit the code, there was a bit of repetition
karelianpie
commented
May 18, 2023
| </p> | ||
| </div> | ||
| )} | ||
| <div className={'mt-2 space-y-2 md:mt-0'}> |
There was a problem hiding this comment.
The real fix, add margin top when in mobile view, as this div falls underneath the previous one and didn't have margin
Majorfi
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix CSS and add a default reward token symbol
Related Issue
Fix #174
Motivation and Context
No issues in the UI
How Has This Been Tested?
Ran locally:
Screenshots (if appropriate):
CSS issue
Reward token symbol missing