Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 0.4.6 release #553

Merged
merged 1 commit into from
Jan 19, 2023
Merged

feat: 0.4.6 release #553

merged 1 commit into from
Jan 19, 2023

Conversation

dudesahn
Copy link
Contributor

@dudesahn dudesahn commented Jan 15, 2023 •
edited
Loading

Increase characters allowed for setSymbol() and setName(), needed for factory vaults

@pandadefi
Copy link
Contributor

One of the integration tests must be fixed.
ethpm-config.yaml must be updated.

storming0x
storming0x reviewed Jan 16, 2023
View reviewed changes
Copy link
Contributor

@storming0x storming0x left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change LGTM small enough to update but CI is failing, needs panda's recommendation

@dudesahn
feat: 0.4.6 release
0286606 
increase max string length for setSymbol() and setName() to match deployment
@dudesahn
Copy link
Contributor Author

dudesahn commented Jan 18, 2023 •
edited
Loading

Output from running tests locally, get the same result on master or on this PR branch. Registry, base fee oracle, and strategy tests all pass.

Screen Shot 2023-01-18 at 12 46 25 PM

Screen Shot 2023-01-18 at 12 46 39 PM

Screen Shot 2023-01-18 at 1 10 49 PM

Vault tests are where we see errors/failures, and it hangs on the test after the error:

Screen Shot 2023-01-18 at 2 02 37 PM

Screen Shot 2023-01-18 at 2 02 42 PM

storming0x
storming0x approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@storming0x storming0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, test work in local but not in CI, and failed test its broken on master so not related to this release branch changes which are minimal and should not affect functionality.

@dudesahn dudesahn merged commit 97ca1b2 into yearn:master Jan 19, 2023
@dudesahn dudesahn deleted the 0-4-6 branch January 19, 2023 21:24
@dudesahn
Copy link
Contributor Author

Deployed contract here: https://etherscan.io/address/0x910e6e8c29e1e02602863535295a531249965294

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Originalmenace Originalmenace Originalmenace approved these changes

@pandadefi pandadefi pandadefi approved these changes

@storming0x storming0x storming0x approved these changes

@rareweasel rareweasel Awaiting requested review from rareweasel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dudesahn @pandadefi @storming0x @Originalmenace