Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump vyper version #494

Merged
merged 1 commit into from
Dec 8, 2021
Merged

chore: bump vyper version #494

merged 1 commit into from
Dec 8, 2021

Conversation

pandadefi
Copy link
Contributor

@pandadefi pandadefi commented Nov 30, 2021

Description

Upgrading the vault version to the latest version of vyper (0.3.0)

Checklist

  • I have run vyper and solidity linting
  • I have run the tests on my machine
  • I have followed commitlint guidelines
  • I have rebased my changes to the latest version of the main branch

@pandadefi pandadefi requested a review from fubuloubu November 30, 2021 10:15
@@ -1,4 +1,4 @@
# @version 0.2.16
# @version 0.3.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v0.3.1 should be released today, should probably try that out

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IncompatibleVyperVersion: No installable vyper version matching '0.3.1' in 'contracts/Vault.vy'

@pandadefi pandadefi mentioned this pull request Dec 1, 2021
@fubuloubu
Copy link
Member

Should work now

@pandadefi
Copy link
Contributor Author

Should work now

still not working

@fubuloubu
Copy link
Member

hmm, works for me... is your brownie up to date?

I see it reduced Vault.vy from 20,397B to 17,951B, a 12% reduction!

@pandadefi
Copy link
Contributor Author

hmm, works for me... is your brownie up to date?

I see it reduced Vault.vy from 20,397B to 17,951B, a 12% reduction!

Test are ok, let's merge this one

@fubuloubu
Copy link
Member

hmm, works for me... is your brownie up to date?
I see it reduced Vault.vy from 20,397B to 17,951B, a 12% reduction!

Test are ok, let's merge this one

Please test this with apetax first

@pandadefi pandadefi merged commit 2088070 into yearn:main Dec 8, 2021
@pandadefi pandadefi deleted the bump_vyper_version branch March 24, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants