Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add pull request template #489

Merged
merged 2 commits into from
Nov 23, 2021
Merged

chore: add pull request template #489

merged 2 commits into from
Nov 23, 2021

Conversation

pandadefi
Copy link
Contributor

Description

We get pull requests that are left unlined with test broken with creators that aren't following up to fix the pull request, I hope adding this guideline will speed up the merge process.

Checklist

  • I have ran vyper and solidity linting
  • I have ran the tests on my machine
  • I have followed commitlint guidelines

@pandadefi pandadefi changed the title Add pull request template chore: add pull request template Nov 22, 2021
@@ -0,0 +1,12 @@
## Description
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if you just name this file .github/PULL_REQUEST_TEMPLATE.md it will work the same way. The folder is only if you have multiple templates.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't sure but I have made the changes.

@pandadefi pandadefi enabled auto-merge (squash) November 23, 2021 15:42
@pandadefi pandadefi merged commit e631726 into yearn:main Nov 23, 2021
@pandadefi pandadefi deleted the add_pull_request_template branch March 24, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants