fix: shares for amount calculation should use freeFunds #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
jmonteer
reviewed
Jun 28, 2021
fubuloubu
reviewed
Jun 28, 2021
added 2 commits
June 28, 2021 21:38
fubuloubu
approved these changes
Jun 29, 2021
|
Should a test be added to cacth this behavior? |
Should we add a function that exposes Otherwise, the test will need to be performed on a withdraw |
On withdrawal sounds appropriate |
jmonteer
approved these changes
Jun 30, 2021
poolpitako
pushed a commit
that referenced
this pull request
Jul 9, 2021
* fix: shares for amount calculation should use freeFunds * refactor: free funds * fix: if check
fubuloubu
pushed a commit
that referenced
this pull request
Jul 9, 2021
* fix: shares for amount calculation should use freeFunds * refactor: free funds * fix: if check
orbxball
pushed a commit
to orbxball/yearn-vaults
that referenced
this pull request
Jul 14, 2021
* fix: shares for amount calculation should use freeFunds * refactor: free funds * fix: if check
orbxball
pushed a commit
to orbxball/yearn-vaults
that referenced
this pull request
Aug 8, 2021
* fix: shares for amount calculation should use freeFunds * refactor: free funds * fix: if check
orbxball
pushed a commit
to orbxball/yearn-vaults
that referenced
this pull request
Aug 8, 2021
* fix: shares for amount calculation should use freeFunds * refactor: free funds * fix: if check
sambacha
pushed a commit
to sambacha/yearn-vaults
that referenced
this pull request
Sep 7, 2021
* fix: shares for amount calculation should use freeFunds * refactor: free funds * fix: if check
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #390