refactor: move condition shares calculation and save gas #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fubuloubu that seems right. |
ghost
requested a review
from 
fubuloubu
approved these changes
May 18, 2021
ghost
pushed a commit
to Grandthrax/yearn-vaults
that referenced
this pull request
May 19, 2021
orbxball
pushed a commit
to orbxball/yearn-vaults
that referenced
this pull request
Aug 8, 2021
sambacha
pushed a commit
to sambacha/yearn-vaults
that referenced
this pull request
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/yearn/yearn-vaults/blob/master/contracts/Vault.vy#L1044
https://github.com/yearn/yearn-vaults/blob/master/contracts/Vault.vy#L1089-L1090
this condition does not change unless tokens are withdrawn from strategies, so move the code to where it can possibly be true.