Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add release drafter #351

Merged
1 commit merged into from May 17, 2021
Merged

feat: add release drafter #351

1 commit merged into from May 17, 2021

Conversation

ghost
Copy link

@ghost ghost commented May 17, 2021

No description provided.

@ghost ghost changed the title Add release drafter feat: add release drafter May 17, 2021
Copy link
Member

@fubuloubu fubuloubu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge after v0.4.0 release

Comment on lines 6 to 7
- 'feature'
- 'enhancement'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these be the conventional commit tags that we use? e.g. feat

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Comment on lines 10 to 12
- 'fix'
- 'bugfix'
- 'bug'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add refactor?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

- 'bugfix'
- 'bug'
change-template: '- $TITLE @$AUTHOR (#$NUMBER)'
change-title-escapes: '\<*_&' # You can add # and @ to disable mentions, and add ` to disable code blocks.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do... 🤔

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Characters to escape in $TITLE when inserting into change-template so that they are not interpreted as Markdown format characters.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see! I do backticks sometimes, but I want that as markdown formatting

@@ -0,0 +1,29 @@
name-template: 'v$RESOLVED_VERSION 🌈'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we like emojis in things?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not like rainbow emojis

.github/workflows/release-drafter.yml Outdated Show resolved Hide resolved
.github/workflows/release-drafter.yml Outdated Show resolved Hide resolved
.github/workflows/release-drafter.yml Outdated Show resolved Hide resolved
Comment on lines 24 to 27
# (Optional) specify config name to use, relative to .github/. Default: release-drafter.yml
# with:
# config-name: my-config.yml
# disable-autolabeler: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does autolabler do?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, yeah I dont care about this lol

@ghost ghost merged commit 6ae6afb into yearn:master May 17, 2021
orbxball pushed a commit to orbxball/yearn-vaults that referenced this pull request Aug 8, 2021
sambacha pushed a commit to sambacha/yearn-vaults that referenced this pull request Sep 7, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant