Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: baseWrapper do not deposit dust #312

Merged
merged 1 commit into from May 11, 2021
Merged

fix: baseWrapper do not deposit dust #312

merged 1 commit into from May 11, 2021

Conversation

ghost
Copy link

@ghost ghost commented May 3, 2021

fixes #305

Doing 10 integration tests on: #313

@ghost ghost changed the title fix: deposit should not happen if amount is lower than price fix: BaseWraper do not deposit if amount is lower than price May 3, 2021
@ghost ghost changed the title fix: BaseWraper do not deposit if amount is lower than price fix: baseWraper do not deposit if amount is lower than price May 3, 2021
@ghost
Copy link
Author

ghost commented May 3, 2021

contracts/BaseWrapper.sol Outdated Show resolved Hide resolved
@fubuloubu fubuloubu changed the title fix: baseWraper do not deposit if amount is lower than price fix: do not deposit dust throw BaseWrapper May 6, 2021
@ghost ghost changed the title fix: do not deposit dust throw BaseWrapper fix: do not deposit dust from BaseWrapper May 7, 2021
@ghost ghost changed the title fix: do not deposit dust from BaseWrapper fix: baseWrapper do not deposit dust May 7, 2021
@fubuloubu fubuloubu merged commit f7a6bf5 into yearn:master May 11, 2021
orbxball pushed a commit to orbxball/yearn-vaults that referenced this pull request Aug 8, 2021
sambacha pushed a commit to sambacha/yearn-vaults that referenced this pull request Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix occasional test case failure
1 participant