Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: setEmergencyExit should allow to be called by vault guardian and vault management #300

Merged
merged 1 commit into from Apr 29, 2021

Conversation

ghost
Copy link

@ghost ghost commented Apr 26, 2021

fixes #294

@ghost ghost changed the base branch from master to develop April 27, 2021 08:35
@ghost ghost changed the base branch from develop to master April 27, 2021 08:38
contracts/BaseStrategy.sol Outdated Show resolved Hide resolved
…d vault management

Co-authored-by: El De-dog-lo <3859395+fubuloubu@users.noreply.github.com>
@fubuloubu
Copy link
Member

Do we want this against develop?

@ghost
Copy link
Author

ghost commented Apr 28, 2021

Do we want this against develop?

Master and develop

@fubuloubu
Copy link
Member

Do we want this against develop?

Master and develop

But do we want against develop first, and then upstream merge to master like last time? This is for an audit comment, right?

@ghost
Copy link
Author

ghost commented Apr 29, 2021

Do we want this against develop?

Master and develop

But do we want against develop first, and then upstream merge to master like last time? This is for an audit comment, right?

That's from a request from @poolpitako
#294

@fubuloubu fubuloubu merged commit 3db9ded into yearn:master Apr 29, 2021
@ghost ghost deleted the setEmergencyExit_should_be_callable_by_vault_guardian_and_management branch April 30, 2021 10:17
orbxball pushed a commit to orbxball/yearn-vaults that referenced this pull request Aug 8, 2021
…d vault management (yearn#300)

Co-authored-by: El De-dog-lo <3859395+fubuloubu@users.noreply.github.com>
sambacha pushed a commit to sambacha/yearn-vaults that referenced this pull request Sep 7, 2021
…d vault management (yearn#300)

Co-authored-by: El De-dog-lo <3859395+fubuloubu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BaseStrategy setEmergencyExit should allow to be called by vault guardian and vault management
1 participant