Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add emergency procedures #295

Merged
merged 3 commits into from
Apr 28, 2021
Merged

feat: add emergency procedures #295

merged 3 commits into from
Apr 28, 2021

Conversation

storming0x
Copy link
Contributor

Change Log:

  • adds emergency MD that details emergency procedures and process for yearn finance

docs/EMERGENCY.md Show resolved Hide resolved

This role will be in charge of coordinating comms and operations assistance as needed:

- Clear with war room what information and communication can be published during and after the incident
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Start the voice channel and keep comms as clean as possible.

docs/EMERGENCY.md Outdated Show resolved Hide resolved
| Communications | Telegram | Discord |
| Transaction Details | [Etherscan](https://etherscan.io/) | [EthTxInfo](https://ethtx.info/) |
| Debugging | Brownie | [Tenderly](https://tenderly.co/) |
| Transaction Builder | [ape-safe](https://github.com/banteg/ape-safe) | Backup if gnosis safe Api is not working?? |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@banteg is there any workaround if gnosis api is down?
Should the emergency-toolbox include interactions with the ms contract directly?

docs/EMERGENCY.md Outdated Show resolved Hide resolved
docs/EMERGENCY.md Outdated Show resolved Hide resolved
docs/EMERGENCY.md Show resolved Hide resolved
docs/EMERGENCY.md Outdated Show resolved Hide resolved
docs/EMERGENCY.md Outdated Show resolved Hide resolved
docs/EMERGENCY.md Outdated Show resolved Hide resolved
feat:  check box for check list

Co-authored-by: El De-dog-lo <3859395+fubuloubu@users.noreply.github.com>
@storming0x storming0x force-pushed the feat/emergency-docs branch from 163d993 to a6b4eee Compare April 26, 2021 14:58
2. Bug in Vault/Strategy code that may cause loss of funds for users
3. An exploit in an underlying protocol that a yearn strategy is utilizing that may lead to loss of funds for the users
4. A bug in an underlying protocol that a yearn strategy is utilizing that may lead to loss of funds for the users
5. A key role like a strategist having the private keys stolen
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If web credentials are compromised, what is our contingency plan?

AWS full admins (all should use 2FA):

  • x48
  • nymmrx
  • Luciano
  • Facu

Domain admins

  • x48
  • Klim

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, what scope should we add here regarding website incidents? wondering if we need the exact same war room configuration for a website incident

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolving this for now to merge the PR, it seems we can create a separate addendum for web related emergencies and later link it to this one.

@lehnberg

This comment has been minimized.

@lehnberg lehnberg force-pushed the feat/emergency-docs branch from 0839e40 to ecea22c Compare April 27, 2021 16:18
@fubuloubu
Copy link
Member

@lehnberg please fix your commit to have a lowercase I on Incorporate

@storming0x storming0x force-pushed the feat/emergency-docs branch from ecea22c to 843fbc8 Compare April 27, 2021 22:27
@fubuloubu
Copy link
Member

@dougstorm good to merge? or needs more review?

@lehnberg
Copy link
Contributor

Apologies @fubuloubu, I struggled with the syntax for conventional commits. Thanks @dougstorm for fixing while I was afk. 🙏

@storming0x storming0x merged commit aa9630a into master Apr 28, 2021
@fubuloubu fubuloubu deleted the feat/emergency-docs branch April 28, 2021 15:05
orbxball pushed a commit to orbxball/yearn-vaults that referenced this pull request Aug 8, 2021
* feat: add emergency procedures

* feat: update docs/EMERGENCY.md

feat:  check box for check list

Co-authored-by: El De-dog-lo <3859395+fubuloubu@users.noreply.github.com>

* docs: incorporate comments and iterate on wording

Co-authored-by: dougstorm <dougstorm@users.noreply.github.com>
Co-authored-by: El De-dog-lo <3859395+fubuloubu@users.noreply.github.com>
Co-authored-by: Daniel Lehnberg <daniel.lehnberg@protonmail.com>
sambacha pushed a commit to sambacha/yearn-vaults that referenced this pull request Sep 7, 2021
* feat: add emergency procedures

* feat: update docs/EMERGENCY.md

feat:  check box for check list

Co-authored-by: El De-dog-lo <3859395+fubuloubu@users.noreply.github.com>

* docs: incorporate comments and iterate on wording

Co-authored-by: dougstorm <dougstorm@users.noreply.github.com>
Co-authored-by: El De-dog-lo <3859395+fubuloubu@users.noreply.github.com>
Co-authored-by: Daniel Lehnberg <daniel.lehnberg@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants