Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update code snippet #293

Merged
merged 2 commits into from
Apr 22, 2021
Merged

fix: update code snippet #293

merged 2 commits into from
Apr 22, 2021

Conversation

orbxball
Copy link
Contributor

@orbxball orbxball commented Apr 22, 2021 •
edited
Loading

fix: update code snippet

@orbxball orbxball changed the title update code snippet fix: update code snippet Apr 22, 2021
fubuloubu
fubuloubu approved these changes Apr 22, 2021
View reviewed changes
Copy link
Member

@fubuloubu fubuloubu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix commit message and lgtm

Edit: use git commit --amend

@storming0x storming0x merged commit 1a1f36c into yearn:master Apr 22, 2021
orbxball added a commit to orbxball/yearn-vaults that referenced this pull request Aug 8, 2021
@orbxball
fix: update code snippet (yearn#293)
04f02db 
* fix: update code snippet

* fix: enclose it in backticks
sambacha pushed a commit to sambacha/yearn-vaults that referenced this pull request Sep 7, 2021
@orbxball @sambacha
fix: update code snippet (yearn#293)
434df5a 
* fix: update code snippet

* fix: enclose it in backticks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@storming0x storming0x storming0x approved these changes

@fubuloubu fubuloubu fubuloubu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@orbxball @fubuloubu @storming0x