fix: check erc20 decimals #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the base branch from
ghost
assigned 
fubuloubu
approved these changes
Apr 22, 2021
fubuloubu
reviewed
Apr 22, 2021
contracts/Vault.vy
Outdated
Comment on lines
284
to
287
| self.decimals = DetailedERC20(token).decimals() | ||
| assert self.decimals < 256 # dev: see VVE-2020-0001 | ||
| if self.decimals < 18: | ||
| self.precisionFactor = 10 ** (18 - self.decimals) |
There was a problem hiding this comment.
We seem to use this result a lot, so it might make sense to cache decimals
Merged
fubuloubu
approved these changes
Apr 22, 2021
fubuloubu
added a commit
that referenced
this pull request
Apr 26, 2021
* fix: do not issue zero shares (#281) * fix: prevent setting wrong reward address (#279) * fix: prevent rewards address to 0x0 or self * fix: test tests/functional/vault/test_config.py Co-authored-by: Just some guy <3859395+fubuloubu@users.noreply.github.com> Co-authored-by: Just some guy <3859395+fubuloubu@users.noreply.github.com> * fix: check erc20 decimals (#283) * fix: initialize function does not validate ERC20 decimals * fix: use cached decimals * fix: shares can be indirectly transferred to 0x0 (#277) Co-authored-by: Just some guy <3859395+fubuloubu@users.noreply.github.com>
orbxball
pushed a commit
to orbxball/yearn-vaults
that referenced
this pull request
Aug 8, 2021
* fix: do not issue zero shares (yearn#281) * fix: prevent setting wrong reward address (yearn#279) * fix: prevent rewards address to 0x0 or self * fix: test tests/functional/vault/test_config.py Co-authored-by: Just some guy <3859395+fubuloubu@users.noreply.github.com> Co-authored-by: Just some guy <3859395+fubuloubu@users.noreply.github.com> * fix: check erc20 decimals (yearn#283) * fix: initialize function does not validate ERC20 decimals * fix: use cached decimals * fix: shares can be indirectly transferred to 0x0 (yearn#277) Co-authored-by: Just some guy <3859395+fubuloubu@users.noreply.github.com>
sambacha
pushed a commit
to sambacha/yearn-vaults
that referenced
this pull request
Sep 7, 2021
* fix: do not issue zero shares (yearn#281) * fix: prevent setting wrong reward address (yearn#279) * fix: prevent rewards address to 0x0 or self * fix: test tests/functional/vault/test_config.py Co-authored-by: Just some guy <3859395+fubuloubu@users.noreply.github.com> Co-authored-by: Just some guy <3859395+fubuloubu@users.noreply.github.com> * fix: check erc20 decimals (yearn#283) * fix: initialize function does not validate ERC20 decimals * fix: use cached decimals * fix: shares can be indirectly transferred to 0x0 (yearn#277) Co-authored-by: Just some guy <3859395+fubuloubu@users.noreply.github.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #282