feat: locked profit on deposit

[Grandthrax]

1 - Make sure that we deposit and withdraw at same share price
2 - Add onreleased profit to next lockedprofit

[fubuloubu]

What testing do we have to make sure this change doesn't introduce a vulnerability?

[storming0x]

can we modify the deposit and withdraw test in brownie for the same block to assert we got the exact amount of want tokens on both operations?

[ghost]

I tought in tests every blockchain call mines a block, I haven't seen an option to batch transactions.
Will look for how that's done.

[fubuloubu]

You can shut off auto-mining

[storming0x]

Changes look good, can we add or edit a test to check that deposit and withdraw in same block cannot make more want than possible?

[fubuloubu]

Disregard failing CI job, was testing something

[fubuloubu]

Change looks good, needs further testing to merge

[ghost]

I am missing something I couldn't find how to include multiple transactions within the same block.

def test_token_amount_does_not_change_on_deposit_withdrawal(chain, gov, token, vault, strategy, rando):
    # set fees to 0
    vault.setManagementFee(0, {"from": gov})
    vault.setPerformanceFee(0, {"from": gov})
    vault.updateStrategyPerformanceFee(strategy, 0, {"from": gov})
    vault.setLockedProfitDegration(
        1e16, {"from": gov}
    )
    web3.provider.make_request("miner_stop", [])

    deposit =vault.deposit(token.balanceOf(gov), {"from": gov, "required_confs": 0})
    withdraw = vault.withdraw({"from": gov,  "required_confs": 0})
    web3.provider.make_request("miner_start", [])
    chain.mine()

    assert(deposit.block == withdraw.block) 

[fubuloubu]

Suggestion from audit: losses should take away from locked profits

[fubuloubu]

rebase on master

[ghost]

Rebased added losses on lockedProfit and force pushed

[ghost]

Found a workaround to mine two transactions within the same block using evm_mine

web3.provider.make_request("evm_mine", [chain.time() + 5])

found the solution UMAprotocol/protocol#1151

[ghost]

Merged 🎉🎉🎉