-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(registry): add ability to track endorsed vault tokens #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Mar 9, 2021
fubuloubu
approved these changes
Mar 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just want to refactor it to something more scalable. tokensList
will cost a lot in gas to update.
fubuloubu
reviewed
Mar 10, 2021
fubuloubu
reviewed
Mar 11, 2021
fubuloubu
approved these changes
Mar 11, 2021
#237 fixes the failure raised in CI |
orbxball
pushed a commit
to orbxball/yearn-vaults
that referenced
this pull request
Mar 22, 2021
* feat(registry): add ability to track endorsed vault tokens * refactor(registry): make token tracking more gas efficient * refactor(registry): implement registry suggestions and refactor test * refactor: minor whitespace shift Co-authored-by: Just some guy <3859395+fubuloubu@users.noreply.github.com>
orbxball
pushed a commit
to orbxball/yearn-vaults
that referenced
this pull request
Aug 8, 2021
* feat(registry): add ability to track endorsed vault tokens * refactor(registry): make token tracking more gas efficient * refactor(registry): implement registry suggestions and refactor test * refactor: minor whitespace shift Co-authored-by: Just some guy <3859395+fubuloubu@users.noreply.github.com>
sambacha
pushed a commit
to sambacha/yearn-vaults
that referenced
this pull request
Sep 7, 2021
* feat(registry): add ability to track endorsed vault tokens * refactor(registry): make token tracking more gas efficient * refactor(registry): implement registry suggestions and refactor test * refactor: minor whitespace shift Co-authored-by: Just some guy <3859395+fubuloubu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to track endorsed vault tokens in the registry.