Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(registry): add ability to track endorsed vault tokens #236

Merged
merged 4 commits into from Mar 11, 2021
Merged

feat(registry): add ability to track endorsed vault tokens #236

merged 4 commits into from Mar 11, 2021

Conversation

ghost
Copy link

@ghost ghost commented Mar 9, 2021

Added the ability to track endorsed vault tokens in the registry.

  • Only support adding tokens if they've not yet been added
  • Only keep track of tokens for endorsed vaults (deployments)

Screen Shot 2021-03-10 at 7 51 00 PM

contracts/Registry.vy Outdated Show resolved Hide resolved
Copy link
Member

@fubuloubu fubuloubu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to refactor it to something more scalable. tokensList will cost a lot in gas to update.

contracts/Registry.vy Outdated Show resolved Hide resolved
contracts/Registry.vy Outdated Show resolved Hide resolved
contracts/Registry.vy Outdated Show resolved Hide resolved
tests/functional/registry/test_deployment.py Outdated Show resolved Hide resolved
contracts/Registry.vy Outdated Show resolved Hide resolved
@fubuloubu
Copy link
Member

#237 fixes the failure raised in CI

@fubuloubu fubuloubu merged commit ddefccc into yearn:master Mar 11, 2021
orbxball pushed a commit to orbxball/yearn-vaults that referenced this pull request Mar 22, 2021
* feat(registry): add ability to track endorsed vault tokens

* refactor(registry): make token tracking more gas efficient

* refactor(registry): implement registry suggestions and refactor test

* refactor: minor whitespace shift

Co-authored-by: Just some guy <3859395+fubuloubu@users.noreply.github.com>
orbxball pushed a commit to orbxball/yearn-vaults that referenced this pull request Aug 8, 2021
* feat(registry): add ability to track endorsed vault tokens

* refactor(registry): make token tracking more gas efficient

* refactor(registry): implement registry suggestions and refactor test

* refactor: minor whitespace shift

Co-authored-by: Just some guy <3859395+fubuloubu@users.noreply.github.com>
sambacha pushed a commit to sambacha/yearn-vaults that referenced this pull request Sep 7, 2021
* feat(registry): add ability to track endorsed vault tokens

* refactor(registry): make token tracking more gas efficient

* refactor(registry): implement registry suggestions and refactor test

* refactor: minor whitespace shift

Co-authored-by: Just some guy <3859395+fubuloubu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant