refactor: add .clone(vault) method to proxy-able BaseStrategy
#214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poolpitako
reviewed
Feb 19, 2021
poolpitako
approved these changes
Feb 19, 2021
fubuloubu
commented
Feb 19, 2021
Co-authored-by: poolpitako <78830419+poolpitako@users.noreply.github.com>
fubuloubu
force-pushed
the
refactor/strategy-clone
branch
from
8a6bee0 to
eaa659b
Compare
|
Looks good 👍 |
|
I couldn't figure out why the failure happens locally, rerunning CI to see if it's just being flakey |
orbxball
pushed a commit
to orbxball/yearn-vaults
that referenced
this pull request
Aug 8, 2021
…n#214) * refactor: add `.clone(vault)` method to proxy-able BaseStrategy * refactor: add ability to choose overloaded clone * fix: intitialize strategy with different roles Co-authored-by: poolpitako <78830419+poolpitako@users.noreply.github.com>
sambacha
pushed a commit
to sambacha/yearn-vaults
that referenced
this pull request
Sep 7, 2021
…n#214) * refactor: add `.clone(vault)` method to proxy-able BaseStrategy * refactor: add ability to choose overloaded clone * fix: intitialize strategy with different roles Co-authored-by: poolpitako <78830419+poolpitako@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplfiies the logic for creating a clone of a strategy that inherits the
BaseStrategyInitializableproxy-enabled base class.