fix: explicitly add Vaults to Registry #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fubuloubu
requested changes
Feb 10, 2021
|
Can this be merge without the changes on #189 ? |
There's no point in merging this until we are ready to re-release the Registry |
|
Rebase this on master |
fubuloubu
approved these changes
Mar 8, 2021
fubuloubu
added a commit
that referenced
this pull request
Mar 15, 2021
* fix: no need to assert governance check of uninitialized vault NOTE: Fix missed in #193 * refactor: merge `_registerRelease` as it's not used more than once * refactor: move `_registerVault` to right before it's used first * test: update test that should now work with this change
orbxball
pushed a commit
to orbxball/yearn-vaults
that referenced
this pull request
Mar 22, 2021
* fix: no need to assert governance check of uninitialized vault NOTE: Fix missed in yearn#193 * refactor: merge `_registerRelease` as it's not used more than once * refactor: move `_registerVault` to right before it's used first * test: update test that should now work with this change
ghost
deleted the
orbxball
pushed a commit
to orbxball/yearn-vaults
that referenced
this pull request
Aug 8, 2021
* fix: no need to assert governance check of uninitialized vault NOTE: Fix missed in yearn#193 * refactor: merge `_registerRelease` as it's not used more than once * refactor: move `_registerVault` to right before it's used first * test: update test that should now work with this change
sambacha
pushed a commit
to sambacha/yearn-vaults
that referenced
this pull request
Sep 7, 2021
* fix: no need to assert governance check of uninitialized vault NOTE: Fix missed in yearn#193 * refactor: merge `_registerRelease` as it's not used more than once * refactor: move `_registerVault` to right before it's used first * test: update test that should now work with this change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #179