Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove ESLint indent, brace-style and comma dangle #269

Closed
wants to merge 5 commits into from

Conversation

karelianpie
Copy link
Member

@karelianpie karelianpie commented Jun 12, 2023

Description

In TypeScript ESLint's indent, brace-style and comma-dangle they recommend not using this rule

Screenshot 2023-06-12 at 20 33 25

More reasons here typescript-eslint/typescript-eslint#1824

"Your specific indent bug might not have an issue created. That does not matter. Don't file a new issue. If you raise an issue we will just close it and reference this issue.
Please don't waste our time by doing that."

"The rule is broken and telling us different ways in which it is broken doesn't change the fact that it is broken."

[Action] We should get prettier https://typescript-eslint.io/linting/troubleshooting/formatting

@karelianpie karelianpie self-assigned this Jun 12, 2023
@karelianpie karelianpie changed the title fix: Remove @typescript-eslint/indent fix: Remove ESLint indent and comma dangle Jun 12, 2023
@karelianpie karelianpie changed the title fix: Remove ESLint indent and comma dangle fix: Remove ESLint indent, brace-style and comma dangle Jun 12, 2023
@karelianpie
Copy link
Member Author

Closing in favor of #300

@karelianpie karelianpie closed this Aug 4, 2023
@Majorfi Majorfi deleted the fix/remove--typescript-eslint-indent branch August 31, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🟢 Done
Development

Successfully merging this pull request may close these issues.

1 participant