-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/Ape Haussmann's renovation #90
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/fameal/ape-tax/G1EMzjnNZ8nQ4KP3kRmxXinXR7k5 |
Someone is attempting to deploy a commit to a Personal Account owned by @fameal on Vercel. @fameal first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll ape merge
What it does ✨
This PR is a large refactoring and rewriting of the ape.tax codebase from Vue to React. Several elements motivated this choice:
The process was quite simple : the design was respected and reproduced, but the whole code has been rewritten with NextJs + Tailwindcss. It will be easy to deploy this version with Vercel, but a few environment variables will need to be added
The following features/improvements were made:
WalletConnect
👛How to test ✅
yarn
.yarn run dev
.Note ℹ️
Don't get me wrong : the previous version was working very nicely. This is just an improvement, but this is a big change. Only to merge if the maintainers think it's worth it!
As the Vercel preview may fail (deployment from Vue to React, here is a preview)