Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Ape Haussmann's renovation #90

Merged
merged 18 commits into from
Aug 23, 2021
Merged

Feature/Ape Haussmann's renovation #90

merged 18 commits into from
Aug 23, 2021

Conversation

TBouder
Copy link
Contributor

@TBouder TBouder commented Aug 22, 2021

What it does ✨

Beginning in 1854, in the centre of the city, Haussmann's renovation tore down hundreds of old buildings and cut eighty kilometres of new avenues. It included the demolition of medieval neighbourhoods that were deemed overcrowded and unhealthy by officials at the time; the building of wide avenues; new parks and squares; the annexation of the suburbs surrounding Paris; and the construction of new sewers, fountains and aqueducts.

This PR is a large refactoring and rewriting of the ape.tax codebase from Vue to React. Several elements motivated this choice:

  • The large community of dev behind React, and the vast number of packages, components and plugins for the Web3 development. 🦍
  • The old codebase didn't follow the Vue standards (written in Python style, which is not standard). 🚨
  • Some nice feature (see bellow) would have taken more time to implement in Vue than rewriting the whole dAPP and theses features in React. ⏰

The process was quite simple : the design was respected and reproduced, but the whole code has been rewritten with NextJs + Tailwindcss. It will be easy to deploy this version with Vercel, but a few environment variables will need to be added

ALCHEMY_KEY -> ALCHEMY_KEY
SECRET -> "ArrowUp,ArrowUp,ArrowDown,ArrowDown,ArrowLeft,ArrowRight,ArrowLeft,ArrowRight,KeyB,KeyA"
WEBSITE_URI -> "https://ape.tax/"

The following features/improvements were made:

  • Adding a support for WalletConnect 👛
  • Reworking the 'Network' select to change the network for the user at the same time ♻️
  • Removing the drizzle usage to migrate with a plain Ethers.js usage 📦
  • Removing the credits for a more generic one for anon reason 👏
  • Support of mobile version 📱
  • Removing the reload between pages for the smoothest experience ⏳
  • Support for mainnet-fork to easy dev 🧪

How to test ✅

  • Install the app with yarn.
  • Launch the app with yarn run dev.
  • You should be able to see the app. You should be able to connect with Metamask or walletConnect.
  • You should be able to see the list of vaults. You should be able to click a vault and get the details about the vault, the strategies and your position.
  • You should be able to approve, withdraw, deposit for any vault (if you have funds), and the vault status should be updated after any action.
  • You should be able to change the network used with the top right select.

Note ℹ️

Don't get me wrong : the previous version was working very nicely. This is just an improvement, but this is a big change. Only to merge if the maintainers think it's worth it!

As the Vercel preview may fail (deployment from Vue to React, here is a preview)

@vercel
Copy link

vercel bot commented Aug 22, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/fameal/ape-tax/G1EMzjnNZ8nQ4KP3kRmxXinXR7k5
✅ Preview: https://ape-tax-git-fork-tbouder-master-fameal.vercel.app

@vercel
Copy link

vercel bot commented Aug 23, 2021

Someone is attempting to deploy a commit to a Personal Account owned by @fameal on Vercel.

@fameal first needs to authorize it.

Copy link
Collaborator

@saltyfacu saltyfacu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll ape merge

@saltyfacu saltyfacu merged commit a9b2cc4 into yearn:master Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature 🚀 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants