-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YQ-2730: use docker-compose random port mapping in connector integration tests #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vitalyisaev2
commented
Jan 12, 2024
•
edited
Loading
edited
- Add retries when making PG connections from connector integration tests
- Use Docker port randomization for data sources launched in containers
Note This is an automated comment that will be appended during run. 🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 0096a23.
🔴 linux-x86_64-release-asan: some tests FAILED for commit 0096a23.
|
tsmax2004
requested changes
Jan 14, 2024
ydb/library/yql/providers/generic/connector/tests/utils/docker_compose.py
Outdated
Show resolved
Hide resolved
ydb/library/yql/providers/generic/connector/tests/utils/docker_compose.py
Outdated
Show resolved
Hide resolved
0452fd3
to
d0e3625
Compare
tsmax2004
approved these changes
Jan 16, 2024
tsmax2004
approved these changes
Jan 16, 2024
uzhastik
approved these changes
Jan 16, 2024
va-kuznecov
pushed a commit
to va-kuznecov/ydb
that referenced
this pull request
Jan 16, 2024
…ion tests (ydb-platform#978) * Use docker-compose random port mapping * Retry creating connections for PostgreSQL * Close ClickHouse and PostgreSQL connections after use
Merged
This was referenced Jan 25, 2024
Merged
Merged
This was referenced Feb 5, 2024
This was referenced Feb 6, 2024
This was referenced Feb 6, 2024
Merged
Merged
Merged
Merged
Merged
Closed
This was referenced Feb 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.