Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare to disable blob header by default in VDisk #9683

Merged

Conversation

alexvru
Copy link
Collaborator

@alexvru alexvru commented Sep 24, 2024

Changelog entry

Prepare to disable blob header by default in VDisk

Changelog category

  • Bugfix

Additional information

Some code was added to enable further switching on AddHeader=false feature for VDisk by default.

Copy link

github-actions bot commented Sep 24, 2024

2024-09-24 08:55:46 UTC Pre-commit check linux-x86_64-release-clang14 for 1bfee4c has started.
2024-09-24 08:55:56 UTC Artifacts will be uploaded here
2024-09-24 08:58:57 UTC ya make is running...
🟢 2024-09-24 09:05:43 UTC Build successful.

Copy link

github-actions bot commented Sep 24, 2024

2024-09-24 08:56:03 UTC Pre-commit check linux-x86_64-release-asan for 1bfee4c has started.
2024-09-24 08:56:13 UTC Artifacts will be uploaded here
2024-09-24 08:59:06 UTC ya make is running...
2024-09-24 10:21:40 UTC Check cancelled

Copy link

github-actions bot commented Sep 24, 2024

2024-09-24 08:56:07 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1bfee4c has started.
2024-09-24 08:56:17 UTC Artifacts will be uploaded here
2024-09-24 08:59:23 UTC ya make is running...
🟡 2024-09-24 10:05:30 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16367 14516 0 15 1793 43

2024-09-24 10:06:52 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-09-24 10:19:01 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
476 (only retried tests) 343 0 6 37 90

2024-09-24 10:19:12 UTC ya make is running... (failed tests rerun, try 3)
🟢 2024-09-24 10:22:16 UTC ydbd size 8.4 GiB changed* by -8.4 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 922ce5c merge: 1bfee4c diff diff %
ydbd size 9 071 190 256 Bytes 9 071 181 616 Bytes -8.4 KiB -0.000%
ydbd stripped size 490 550 600 Bytes 490 551 112 Bytes +512 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
2024-09-24 10:22:17 UTC Check cancelled

@alexvru alexvru force-pushed the vdisk/fix-no-header-vdisk-processing branch from d8ddee3 to e3a5054 Compare September 24, 2024 10:21
Copy link

github-actions bot commented Sep 24, 2024

2024-09-24 10:26:03 UTC Pre-commit check linux-x86_64-relwithdebinfo for 2290bcf has started.
2024-09-24 10:26:13 UTC Artifacts will be uploaded here
2024-09-24 10:29:12 UTC ya make is running...
🟡 2024-09-24 11:36:16 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16367 14700 0 14 1617 36

2024-09-24 11:37:38 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-09-24 11:49:20 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
297 (only retried tests) 195 0 3 7 92

2024-09-24 11:49:29 UTC ya make is running... (failed tests rerun, try 3)
🟢 2024-09-24 11:50:49 UTC ydbd size 8.4 GiB changed* by -5.3 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 922ce5c merge: 2290bcf diff diff %
ydbd size 9 071 190 256 Bytes 9 071 184 872 Bytes -5.3 KiB -0.000%
ydbd stripped size 490 550 600 Bytes 490 551 496 Bytes +896 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
2024-09-24 11:50:51 UTC Check cancelled

Copy link

github-actions bot commented Sep 24, 2024

2024-09-24 10:26:08 UTC Pre-commit check linux-x86_64-release-asan for 2290bcf has started.
2024-09-24 10:26:18 UTC Artifacts will be uploaded here
2024-09-24 10:29:11 UTC ya make is running...
2024-09-24 11:50:13 UTC Check cancelled

Copy link

github-actions bot commented Sep 24, 2024

2024-09-24 10:26:20 UTC Pre-commit check linux-x86_64-release-clang14 for 2290bcf has started.
2024-09-24 10:26:44 UTC Artifacts will be uploaded here
2024-09-24 10:30:06 UTC ya make is running...
🟢 2024-09-24 10:37:12 UTC Build successful.

@alexvru alexvru force-pushed the vdisk/fix-no-header-vdisk-processing branch from e3a5054 to b483fed Compare September 24, 2024 11:49
Copy link

github-actions bot commented Sep 24, 2024

2024-09-24 12:01:29 UTC Pre-commit check linux-x86_64-release-clang14 for ef92706 has started.
2024-09-24 12:01:39 UTC Artifacts will be uploaded here
2024-09-24 12:04:47 UTC ya make is running...
🟢 2024-09-24 12:14:48 UTC Build successful.

Copy link

github-actions bot commented Sep 24, 2024

2024-09-24 12:02:02 UTC Pre-commit check linux-x86_64-relwithdebinfo for ef92706 has started.
2024-09-24 12:02:34 UTC Artifacts will be uploaded here
2024-09-24 12:05:46 UTC ya make is running...
🟡 2024-09-24 13:15:02 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16375 14725 0 8 1606 36

2024-09-24 13:16:25 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-24 13:27:52 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
278 (only retried tests) 179 0 0 7 92

🟢 2024-09-24 13:28:00 UTC Build successful.
🟢 2024-09-24 13:28:39 UTC ydbd size 8.4 GiB changed* by -29.8 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 4b0a8a2 merge: ef92706 diff diff %
ydbd size 9 073 135 848 Bytes 9 073 105 344 Bytes -29.8 KiB -0.000%
ydbd stripped size 490 581 768 Bytes 490 577 800 Bytes -3.9 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 24, 2024

2024-09-24 12:02:25 UTC Pre-commit check linux-x86_64-release-asan for ef92706 has started.
2024-09-24 12:03:04 UTC Artifacts will be uploaded here
2024-09-24 12:06:31 UTC ya make is running...
🔴 2024-09-24 13:52:58 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11718 11503 0 46 51 118

🟢 2024-09-24 13:54:01 UTC Build successful.
🟢 2024-09-24 13:54:32 UTC ydbd size 5.7 GiB changed* by +8.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a19277a merge: ef92706 diff diff %
ydbd size 6 080 164 376 Bytes 6 080 172 720 Bytes +8.1 KiB +0.000%
ydbd stripped size 1 520 042 160 Bytes 1 520 047 344 Bytes +5.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexvru alexvru merged commit 18174b0 into ydb-platform:main Sep 24, 2024
10 of 12 checks passed
@alexvru alexvru deleted the vdisk/fix-no-header-vdisk-processing branch September 24, 2024 14:07
rekby pushed a commit to rekby-forks/ydb that referenced this pull request Sep 24, 2024
@alexvru alexvru self-assigned this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants