Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cancel after in rate limiter #9486

Conversation

UgnineSirdis
Copy link
Collaborator

(cherry picked from commit a430757)

Changelog entry

There is a problem in handling operation_timeout parameter during rate limiter request. The ways how in works causes race, when rate limiter can reply OK (and spend resource), but RPC timeout will say to the user that request timeouted.
It is much better to support more safe cancel_after parameter < operation_timeout. In this case response will be consistent with quoter service.

Changelog category

  • New feature

Additional information

...

@UgnineSirdis UgnineSirdis requested a review from a team as a code owner September 19, 2024 09:18
Copy link

github-actions bot commented Sep 19, 2024

2024-09-19 09:22:17 UTC Pre-commit check for dfdb0ba has started.
2024-09-19 09:25:30 UTC Build linux-x86_64-release-asan is running...
🟢 2024-09-19 09:50:11 UTC Build successful.
2024-09-19 09:50:29 UTC Tests are running...
🔴 2024-09-19 12:08:36 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15785 15660 0 40 50 35

🟢 2024-09-19 12:09:25 UTC ydbd size 5.5 GiB changed* by +47.0 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: 590ac64 merge: dfdb0ba diff diff %
ydbd size 5 935 242 400 Bytes 5 935 290 544 Bytes +47.0 KiB +0.001%
ydbd stripped size 1 487 985 984 Bytes 1 487 994 560 Bytes +8.4 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 19, 2024

2024-09-19 09:22:20 UTC Pre-commit check for dfdb0ba has started.
2024-09-19 09:25:11 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-09-19 09:34:44 UTC Build successful.

Copy link

github-actions bot commented Sep 19, 2024

2024-09-19 09:22:23 UTC Pre-commit check for dfdb0ba has started.
2024-09-19 09:25:04 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-09-19 10:07:03 UTC Build successful.
2024-09-19 10:07:17 UTC Tests are running...
🔴 2024-09-19 12:17:51 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
76870 63412 0 6 13420 32

🟢 2024-09-19 12:18:36 UTC ydbd size 8.2 GiB changed* by +57.3 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: 590ac64 merge: dfdb0ba diff diff %
ydbd size 8 763 585 296 Bytes 8 763 643 992 Bytes +57.3 KiB +0.001%
ydbd stripped size 479 088 456 Bytes 479 091 592 Bytes +3.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@UgnineSirdis UgnineSirdis merged commit 97ff008 into ydb-platform:stable-24-3 Sep 24, 2024
8 of 12 checks passed
uzhastik pushed a commit to uzhastik/ydb that referenced this pull request Oct 2, 2024
@UgnineSirdis UgnineSirdis deleted the rate-limiter-cancel-after-24-3 branch October 7, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants