Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24-3: Do not lose ScanShards when altering #9377

Conversation

CyberROFL
Copy link
Member

@CyberROFL CyberROFL commented Sep 17, 2024

Changelog entry

Fixed a bug where an invariant could be violated in SchemeShard after the CDC initial scan.

Changelog category

  • Bugfix

Additional information

...

@CyberROFL CyberROFL marked this pull request as ready for review September 17, 2024 12:51
@CyberROFL CyberROFL requested a review from a team as a code owner September 17, 2024 12:51
Copy link

github-actions bot commented Sep 17, 2024

2024-09-17 12:51:33 UTC Pre-commit check for 57428eb has started.
2024-09-17 12:54:07 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-09-17 13:03:19 UTC Build successful.

@CyberROFL CyberROFL self-assigned this Sep 17, 2024
Copy link

github-actions bot commented Sep 17, 2024

2024-09-17 12:52:52 UTC Pre-commit check for 57428eb has started.
2024-09-17 12:55:28 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-09-17 13:36:24 UTC Build successful.
2024-09-17 13:36:41 UTC Tests are running...
🔴 2024-09-17 15:20:21 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38553 33306 0 6 5212 29

🟡 2024-09-17 15:21:08 UTC ydbd size 8.2 GiB changed* by +535.4 KiB, which is >= 100.0 KiB vs stable-24-3: Warning

ydbd size dash stable-24-3: 4255d09 merge: 57428eb diff diff %
ydbd size 8 762 487 056 Bytes 8 763 035 352 Bytes +535.4 KiB +0.006%
ydbd stripped size 479 058 024 Bytes 479 068 520 Bytes +10.2 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 17, 2024

2024-09-17 12:55:21 UTC Pre-commit check for 57428eb has started.
2024-09-17 12:57:55 UTC Build linux-x86_64-release-asan is running...
🟢 2024-09-17 13:22:34 UTC Build successful.
2024-09-17 13:22:49 UTC Tests are running...
🔴 2024-09-17 15:21:03 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10019 9954 0 7 26 32

🟢 2024-09-17 15:21:50 UTC ydbd size 5.5 GiB changed* by +4.4 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: c68e211 merge: 57428eb diff diff %
ydbd size 5 935 967 176 Bytes 5 935 971 648 Bytes +4.4 KiB +0.000%
ydbd stripped size 1 488 130 528 Bytes 1 488 131 680 Bytes +1.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@CyberROFL CyberROFL enabled auto-merge (squash) September 17, 2024 14:33
@CyberROFL CyberROFL merged commit 43b3f6e into ydb-platform:stable-24-3 Sep 17, 2024
8 of 12 checks passed
@CyberROFL CyberROFL deleted the racy-alter-stream-and-restart-24-3 branch September 17, 2024 16:36
uzhastik pushed a commit to uzhastik/ydb that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants