Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the TEvTxCalcPredicate message for the completed transaction (#8809) #9225

Merged

Conversation

Alek5andr-Kotov
Copy link
Collaborator

Changelog entry

Moved the fixes from the main branch.

After restarting, the PQ tablet can re-send the message TEvTxCalcPredicate to the partition. Currently, the actor of the partition does not check the PlanStep messages. This is a mistake. Since if he has already completed this transaction before, the predicate will be calculated incorrectly. As a result, the transaction may be partially completed.

Changelog category

  • Bugfix
  • Not for changelog (changelog entry is not required)

Additional information

...

@Alek5andr-Kotov Alek5andr-Kotov requested a review from a team as a code owner September 13, 2024 13:22
Copy link

github-actions bot commented Sep 13, 2024

2024-09-13 13:23:34 UTC Pre-commit check for d5a5108 has started.
2024-09-13 13:26:37 UTC Build linux-x86_64-release-asan is running...
🟢 2024-09-13 13:49:53 UTC Build successful.
2024-09-13 13:50:08 UTC Tests are running...
🔴 2024-09-13 15:59:28 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11173 11088 0 23 28 34

🟢 2024-09-13 16:00:16 UTC ydbd size 5.5 GiB changed* by +84.8 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: 1b9a283 merge: d5a5108 diff diff %
ydbd size 5 935 567 616 Bytes 5 935 654 400 Bytes +84.8 KiB +0.001%
ydbd stripped size 1 488 041 632 Bytes 1 488 050 080 Bytes +8.2 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 13, 2024

2024-09-13 13:29:09 UTC Pre-commit check for d5a5108 has started.
2024-09-13 13:31:44 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-09-13 13:42:25 UTC Build successful.

@Alek5andr-Kotov Alek5andr-Kotov merged commit 25a5416 into ydb-platform:stable-24-3 Sep 13, 2024
3 of 9 checks passed
Copy link

github-actions bot commented Sep 13, 2024

2024-09-13 13:47:08 UTC Pre-commit check for d5a5108 has started.
2024-09-13 13:49:39 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-09-13 14:29:34 UTC Build successful.
2024-09-13 14:29:49 UTC Tests are running...
🔴 2024-09-13 15:54:01 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15476 14137 0 6 1301 32

🟢 2024-09-13 15:54:43 UTC ydbd size 8.2 GiB changed* by +21.2 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: 3033104 merge: d5a5108 diff diff %
ydbd size 8 762 361 896 Bytes 8 762 383 568 Bytes +21.2 KiB +0.000%
ydbd stripped size 479 045 768 Bytes 479 047 048 Bytes +1.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants