Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basic statistics bugfixes KIKIMR-18323 #915

Merged
merged 1 commit into from
Jan 12, 2024
+6 −0
Merged

basic statistics bugfixes KIKIMR-18323 #915

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
basic statistics bugfixes KIKIMR-18323
@alexd65536
alexd65536 committed Jan 10, 2024
commit 74338e72c2a1fd2eb71799e254f0270bc756951c
2 changes: 2 additions & 0 deletions ydb/core/cms/console/console__create_tenant.cpp
View file
Original file line number Diff line number Diff line change
@@ -217,6 +217,8 @@ class TTenantsManager::TTxCreateTenant : public TTransactionBase<TTenantsManager
break;

case Ydb::Cms::CreateDatabaseRequest::kServerlessResources:
Tenant->IsExternalStatisticsAggregator = false;

if (!Tenant->IsExternalSubdomain) {
return Error(Ydb::StatusIds::PRECONDITION_FAILED,
"Cannot create serverless database unless external subdomain is enabled", ctx);
4 changes: 4 additions & 0 deletions ydb/core/statistics/aggregator/aggregator_impl.cpp
View file
Original file line number Diff line number Diff line change
@@ -102,6 +102,10 @@ void TStatisticsAggregator::Handle(TEvStatistics::TEvConnectNode::TPtr& ev) {
IsPropagateInFlight = true;
}

if (!record.NeedSchemeShardsSize()) {
return;
}

std::vector<TSSId> ssIds;
ssIds.reserve(record.NeedSchemeShardsSize());
for (const auto& ssId : record.GetNeedSchemeShards()) {