Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return 0 when field is zero #8955

Merged
merged 1 commit into from
Sep 10, 2024
Merged

return 0 when field is zero #8955

merged 1 commit into from
Sep 10, 2024

Conversation

adameat
Copy link
Member

@adameat adameat commented Sep 9, 2024

Changelog entry

return 0 when field is zero
closes #8953

Changelog category

  • Bugfix
  • Not for changelog (changelog entry is not required)

@adameat adameat requested a review from a team as a code owner September 9, 2024 12:26
@github-actions github-actions bot added the bugfix label Sep 9, 2024
Copy link

github-actions bot commented Sep 9, 2024

2024-09-09 12:29:11 UTC Pre-commit check linux-x86_64-release-clang14 for db9307e has started.
2024-09-09 12:32:03 UTC ya make is running...
🟢 2024-09-09 12:38:41 UTC Build successful.

@adameat adameat enabled auto-merge (squash) September 9, 2024 12:33
Copy link

github-actions bot commented Sep 9, 2024

2024-09-09 12:35:11 UTC Pre-commit check linux-x86_64-relwithdebinfo for db9307e has started.
2024-09-09 12:39:56 UTC ya make is running...
🟡 2024-09-09 14:04:38 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40678 35126 0 19 5505 28

2024-09-09 14:08:10 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-09-09 14:18:31 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
137 (only retried tests) 113 0 4 0 20

2024-09-09 14:18:39 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-09-09 14:27:31 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
30 (only retried tests) 8 0 4 0 18

🟢 2024-09-09 14:27:38 UTC Build successful.
🟢 2024-09-09 14:28:21 UTC ydbd size 8.4 GiB changed* by +488 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: d7a78d0 merge: db9307e diff diff %
ydbd size 9 017 351 232 Bytes 9 017 351 720 Bytes +488 Bytes +0.000%
ydbd stripped size 487 427 464 Bytes 487 427 720 Bytes +256 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 9, 2024

2024-09-09 12:41:43 UTC Pre-commit check linux-x86_64-release-asan for db9307e has started.
2024-09-09 12:45:45 UTC ya make is running...
🔴 2024-09-09 14:31:24 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11423 11332 0 32 30 29

🟢 2024-09-09 14:32:24 UTC Build successful.
🟢 2024-09-09 14:32:58 UTC ydbd size 5.6 GiB changed* by +1.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: d7a78d0 merge: db9307e diff diff %
ydbd size 6 032 166 104 Bytes 6 032 167 800 Bytes +1.7 KiB +0.000%
ydbd stripped size 1 510 171 088 Bytes 1 510 173 008 Bytes +1.9 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@adameat adameat added the rebase-and-check Rebase PR with the current base branch and check label Sep 10, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Sep 10, 2024
Copy link

2024-09-10 05:46:18 UTC Pre-commit check linux-x86_64-release-clang14 for bf49e95 has started.

Copy link

2024-09-10 05:46:28 UTC Pre-commit check linux-x86_64-release-asan for bf49e95 has started.

Copy link

2024-09-10 05:47:07 UTC Pre-commit check linux-x86_64-relwithdebinfo for bf49e95 has started.

@adameat adameat added the rebase-and-check Rebase PR with the current base branch and check label Sep 10, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Sep 10, 2024
Copy link

github-actions bot commented Sep 10, 2024

2024-09-10 08:34:46 UTC Pre-commit check linux-x86_64-release-clang14 for 5b09d4e has started.
2024-09-10 08:37:38 UTC ya make is running...
🟢 2024-09-10 08:43:44 UTC Build successful.

Copy link

github-actions bot commented Sep 10, 2024

2024-09-10 08:35:11 UTC Pre-commit check linux-x86_64-release-asan for 5b09d4e has started.
2024-09-10 08:38:09 UTC ya make is running...
🔴 2024-09-10 10:29:12 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11431 11313 0 41 42 35

🟢 2024-09-10 10:30:11 UTC Build successful.
🟢 2024-09-10 10:30:48 UTC ydbd size 5.6 GiB changed* by +1.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 4a8eeda merge: 5b09d4e diff diff %
ydbd size 6 036 912 800 Bytes 6 036 914 496 Bytes +1.7 KiB +0.000%
ydbd stripped size 1 511 084 976 Bytes 1 511 086 896 Bytes +1.9 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 10, 2024

2024-09-10 08:35:19 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5b09d4e has started.
2024-09-10 08:38:17 UTC ya make is running...
🟡 2024-09-10 09:50:10 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40688 35224 0 6 5431 27

2024-09-10 09:54:09 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-10 10:04:11 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
44 (only retried tests) 25 0 0 0 19

🟢 2024-09-10 10:04:18 UTC Build successful.
🟢 2024-09-10 10:04:57 UTC ydbd size 8.4 GiB changed* by +424 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 4a8eeda merge: 5b09d4e diff diff %
ydbd size 9 024 182 440 Bytes 9 024 182 864 Bytes +424 Bytes +0.000%
ydbd stripped size 487 703 400 Bytes 487 703 592 Bytes +192 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@adameat adameat merged commit a0855f6 into ydb-platform:main Sep 10, 2024
16 of 23 checks passed
@shnikd shnikd mentioned this pull request Sep 11, 2024
adameat added a commit to adameat/ydb that referenced this pull request Oct 1, 2024
adameat added a commit to adameat/ydb that referenced this pull request Oct 4, 2024
@adameat adameat deleted the fix-zeros branch November 14, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

return 0 for zero values (but not for absent ones)
3 participants