Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove table only for empty insert table #8822

Merged
merged 16 commits into from
Sep 8, 2024
Merged

remove table only for empty insert table #8822

merged 16 commits into from
Sep 8, 2024

Conversation

ivanmorozov333
Copy link
Collaborator

restore return and additional logging

  • Bugfix

@github-actions github-actions bot added the bugfix label Sep 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024 •
edited
Loading

⚪ 2024-09-05 17:30:14 UTC Pre-commit check linux-x86_64-release-clang14 for 10eb996 has started.
⚪ 2024-09-05 17:33:01 UTC ya make is running...
🟢 2024-09-05 17:41:01 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024 •
edited
Loading

⚪ 2024-09-05 17:33:24 UTC Pre-commit check linux-x86_64-relwithdebinfo for 10eb996 has started.
⚪ 2024-09-05 17:37:17 UTC ya make is running...
🟡 2024-09-05 18:42:16 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14487 13080 0 7 1371 29

⚪ 2024-09-05 18:43:32 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-05 18:53:27 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
51 (only retried tests) 29 0 0 1 21

🟢 2024-09-05 18:53:36 UTC Build successful.
🟢 2024-09-05 18:54:11 UTC ydbd size 8.4 GiB changed* by +20.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 0923723 merge: 10eb996 diff diff %
ydbd size 8 999 711 248 Bytes 8 999 732 696 Bytes +20.9 KiB +0.000%
ydbd stripped size 486 651 784 Bytes 486 654 472 Bytes +2.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024 •
edited
Loading

⚪ 2024-09-05 17:37:06 UTC Pre-commit check linux-x86_64-release-asan for 10eb996 has started.
⚪ 2024-09-05 17:39:56 UTC ya make is running...
🔴 2024-09-05 19:25:25 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10043 9950 0 31 30 32

🟢 2024-09-05 19:26:20 UTC Build successful.
🟢 2024-09-05 19:26:56 UTC ydbd size 5.6 GiB changed* by +15.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 0923723 merge: 10eb996 diff diff %
ydbd size 6 017 850 224 Bytes 6 017 866 472 Bytes +15.9 KiB +0.000%
ydbd stripped size 1 507 095 888 Bytes 1 507 098 640 Bytes +2.7 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 6, 2024 •
edited
Loading

⚪ 2024-09-06 08:47:37 UTC Pre-commit check linux-x86_64-release-clang14 for c64c80e has started.
⚪ 2024-09-06 08:50:37 UTC ya make is running...
🔴 2024-09-06 08:55:10 UTC Build failed. see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 6, 2024 •
edited
Loading

⚪ 2024-09-06 08:47:53 UTC Pre-commit check linux-x86_64-release-asan for c64c80e has started.
⚪ 2024-09-06 08:50:45 UTC ya make is running...
🔴 2024-09-06 08:54:11 UTC Build failed. see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 6, 2024 •
edited
Loading

⚪ 2024-09-06 08:49:39 UTC Pre-commit check linux-x86_64-relwithdebinfo for c64c80e has started.
⚪ 2024-09-06 08:53:29 UTC ya make is running...
🔴 2024-09-06 08:57:43 UTC Build failed. see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 7, 2024 •
edited
Loading

⚪ 2024-09-07 08:50:43 UTC Pre-commit check linux-x86_64-release-clang14 for ae3d3fc has started.
⚪ 2024-09-07 08:53:37 UTC ya make is running...
⚫ 2024-09-07 08:58:58 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 7, 2024 •
edited
Loading

⚪ 2024-09-07 08:50:51 UTC Pre-commit check linux-x86_64-relwithdebinfo for ae3d3fc has started.
⚪ 2024-09-07 08:53:47 UTC ya make is running...
⚫ 2024-09-07 08:59:00 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 7, 2024 •
edited
Loading

⚪ 2024-09-07 08:50:55 UTC Pre-commit check linux-x86_64-release-asan for ae3d3fc has started.
⚪ 2024-09-07 08:53:50 UTC ya make is running...
🔴 2024-09-07 08:57:38 UTC Build failed, see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 7, 2024 •
edited
Loading

⚪ 2024-09-07 09:03:22 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3660c71 has started.
⚪ 2024-09-07 09:06:33 UTC ya make is running...
🟡 2024-09-07 10:31:55 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40645 35180 0 9 5429 27

⚪ 2024-09-07 10:35:25 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-07 10:45:45 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
54 (only retried tests) 34 0 0 1 19

🟢 2024-09-07 10:45:52 UTC Build successful.
🟡 2024-09-07 10:46:36 UTC ydbd size 8.4 GiB changed* by +941.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: de9b991 merge: 3660c71 diff diff %
ydbd size 9 014 340 008 Bytes 9 015 304 416 Bytes +941.8 KiB +0.011%
ydbd stripped size 487 349 096 Bytes 487 385 576 Bytes +35.6 KiB +0.007%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 7, 2024 •
edited
Loading

⚪ 2024-09-07 09:05:30 UTC Pre-commit check linux-x86_64-release-clang14 for 3660c71 has started.
⚪ 2024-09-07 09:08:23 UTC ya make is running...
🟢 2024-09-07 09:24:51 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 7, 2024 •
edited
Loading

⚪ 2024-09-07 09:06:01 UTC Pre-commit check linux-x86_64-release-asan for 3660c71 has started.
⚪ 2024-09-07 09:09:10 UTC ya make is running...
🔴 2024-09-07 11:15:26 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11411 11247 0 54 69 41

🟢 2024-09-07 11:16:25 UTC Build successful.
🟡 2024-09-07 11:17:04 UTC ydbd size 5.6 GiB changed* by +777.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: de9b991 merge: 3660c71 diff diff %
ydbd size 6 030 031 240 Bytes 6 030 827 504 Bytes +777.6 KiB +0.013%
ydbd stripped size 1 509 853 520 Bytes 1 510 002 640 Bytes +145.6 KiB +0.010%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 7, 2024 •
edited
Loading

⚪ 2024-09-07 12:34:10 UTC Pre-commit check linux-x86_64-release-clang14 for 74ccc13 has started.
⚪ 2024-09-07 12:37:08 UTC ya make is running...
🟢 2024-09-07 13:06:53 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 7, 2024 •
edited
Loading

⚪ 2024-09-07 12:34:29 UTC Pre-commit check linux-x86_64-relwithdebinfo for 74ccc13 has started.
⚪ 2024-09-07 12:37:33 UTC ya make is running...
🟡 2024-09-07 14:05:51 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40658 35200 0 6 5428 24

🟡 2024-09-07 14:08:41 UTC ydbd size 8.4 GiB changed* by +899.7 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: de9b991 merge: 74ccc13 diff diff %
ydbd size 9 014 340 008 Bytes 9 015 261 312 Bytes +899.7 KiB +0.010%
ydbd stripped size 487 349 096 Bytes 487 386 664 Bytes +36.7 KiB +0.008%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
⚫ 2024-09-07 14:08:43 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 7, 2024 •
edited
Loading

⚪ 2024-09-07 12:34:54 UTC Pre-commit check linux-x86_64-release-asan for 74ccc13 has started.
⚪ 2024-09-07 12:38:04 UTC ya make is running...
⚫ 2024-09-07 14:08:16 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 7, 2024 •
edited
Loading

⚪ 2024-09-07 14:12:08 UTC Pre-commit check linux-x86_64-release-asan for 2adc0a0 has started.
⚪ 2024-09-07 14:15:09 UTC ya make is running...
🔴 2024-09-07 14:26:09 UTC Build failed, see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 7, 2024 •
edited
Loading

⚪ 2024-09-07 14:12:37 UTC Pre-commit check linux-x86_64-release-clang14 for 2adc0a0 has started.
⚪ 2024-09-07 14:15:51 UTC ya make is running...
🔴 2024-09-07 14:29:41 UTC Build failed, see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 7, 2024 •
edited
Loading

⚪ 2024-09-07 14:13:07 UTC Pre-commit check linux-x86_64-relwithdebinfo for 2adc0a0 has started.
⚪ 2024-09-07 14:16:23 UTC ya make is running...
🔴 2024-09-07 14:28:21 UTC Build failed, see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 7, 2024 •
edited
Loading

⚪ 2024-09-07 14:41:34 UTC Pre-commit check linux-x86_64-release-clang14 for 92c7255 has started.
⚪ 2024-09-07 14:44:37 UTC ya make is running...
🔴 2024-09-07 14:48:51 UTC Build failed, see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 7, 2024 •
edited
Loading

⚪ 2024-09-07 14:41:36 UTC Pre-commit check linux-x86_64-release-asan for 92c7255 has started.
⚪ 2024-09-07 14:44:35 UTC ya make is running...
🔴 2024-09-07 14:50:08 UTC Build failed, see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 7, 2024 •
edited
Loading

⚪ 2024-09-07 14:44:26 UTC Pre-commit check linux-x86_64-relwithdebinfo for 92c7255 has started.
⚪ 2024-09-07 14:47:29 UTC ya make is running...
⚫ 2024-09-07 14:51:04 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 7, 2024 •
edited
Loading

⚪ 2024-09-07 14:53:34 UTC Pre-commit check linux-x86_64-release-asan for 0bd5a77 has started.
⚪ 2024-09-07 14:56:48 UTC ya make is running...
🔴 2024-09-07 15:03:46 UTC Build failed, see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 7, 2024 •
edited
Loading

⚪ 2024-09-07 14:54:14 UTC Pre-commit check linux-x86_64-release-clang14 for 0bd5a77 has started.
⚪ 2024-09-07 14:57:13 UTC ya make is running...
🔴 2024-09-07 15:01:06 UTC Build failed, see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 7, 2024 •
edited
Loading

⚪ 2024-09-07 14:56:25 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0bd5a77 has started.
⚪ 2024-09-07 14:59:25 UTC ya make is running...
🔴 2024-09-07 15:06:44 UTC Build failed, see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 7, 2024 •
edited
Loading

⚪ 2024-09-07 15:21:17 UTC Pre-commit check linux-x86_64-release-asan for a6b2166 has started.
⚪ 2024-09-07 15:24:16 UTC ya make is running...
🔴 2024-09-07 16:58:10 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11391 11316 0 12 32 31

🟢 2024-09-07 16:59:07 UTC Build successful.
🟡 2024-09-07 17:00:14 UTC ydbd size 5.6 GiB changed* by +793.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: de9b991 merge: a6b2166 diff diff %
ydbd size 6 030 031 240 Bytes 6 030 843 648 Bytes +793.4 KiB +0.013%
ydbd stripped size 1 509 853 520 Bytes 1 510 007 280 Bytes +150.2 KiB +0.010%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 7, 2024 •
edited
Loading

⚪ 2024-09-07 15:21:19 UTC Pre-commit check linux-x86_64-release-clang14 for a6b2166 has started.
⚪ 2024-09-07 15:24:20 UTC ya make is running...
🟢 2024-09-07 15:30:23 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 7, 2024 •
edited
Loading

⚪ 2024-09-07 15:21:29 UTC Pre-commit check linux-x86_64-relwithdebinfo for a6b2166 has started.
⚪ 2024-09-07 15:24:29 UTC ya make is running...
🟡 2024-09-07 16:34:08 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40660 35198 0 8 5429 25

⚪ 2024-09-07 16:37:39 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-07 16:44:24 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
47 (only retried tests) 29 0 0 0 18

🟢 2024-09-07 16:44:31 UTC Build successful.
🟡 2024-09-07 16:45:10 UTC ydbd size 8.4 GiB changed* by +857.5 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: de9b991 merge: a6b2166 diff diff %
ydbd size 9 014 340 008 Bytes 9 015 218 072 Bytes +857.5 KiB +0.010%
ydbd stripped size 487 349 096 Bytes 487 385 576 Bytes +35.6 KiB +0.007%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ivanmorozov333 ivanmorozov333 marked this pull request as ready for review September 8, 2024 11:04
@ivanmorozov333 ivanmorozov333 merged commit c0d60de into ydb-platform:main Sep 8, 2024
10 of 12 checks passed
@ivanmorozov333 ivanmorozov333 deleted the fixes branch September 8, 2024 11:04
@niksaveliev niksaveliev mentioned this pull request Sep 9, 2024
Merged
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 10, 2024
@ivanmorozov333 @zverevgeny
remove table only for empty insert table (ydb-platform#8822)
7b4429e
@GrigoriyPA GrigoriyPA mentioned this pull request Sep 10, 2024
Merged
@shnikd shnikd mentioned this pull request Sep 11, 2024
Closed
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 11, 2024
@ivanmorozov333 @zverevgeny
remove table only for empty insert table (ydb-platform#8822)
fe46328
@niksaveliev niksaveliev mentioned this pull request Sep 12, 2024
Merged
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 13, 2024
@ivanmorozov333 @zverevgeny
remove table only for empty insert table (ydb-platform#8822)
1748c39 
Conflicts:
	ydb/core/tx/columnshard/engines/scheme/index_info.cpp
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 15, 2024
@ivanmorozov333 @zverevgeny
remove table only for empty insert table (ydb-platform#8822)
f330c16 
Conflicts:
	ydb/core/tx/columnshard/engines/scheme/index_info.cpp
@zverevgeny zverevgeny mentioned this pull request Sep 16, 2024
Closed
@StekPerepolnen StekPerepolnen mentioned this pull request Sep 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zverevgeny zverevgeny zverevgeny approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivanmorozov333 @zverevgeny