Use lock-free Bucket in CostTracker with limited underflow #8637

serbel324 · 2024-09-02T18:19:17Z

Changelog entry

...

Changelog category

Improvement
Performance improvement

Additional information

...

github-actions · 2024-09-02T18:21:16Z

⚪ 2024-09-02 18:21:16 UTC Pre-commit check linux-x86_64-release-clang14 for d585e91 has started.
⚫ 2024-09-02 18:22:33 UTC Check cancelled

github-actions · 2024-09-02T18:23:58Z

⚪ 2024-09-02 18:23:58 UTC Pre-commit check linux-x86_64-release-clang14 for 5aba053 has started.
⚪ 2024-09-02 18:26:45 UTC ya make is running...
🟢 2024-09-02 18:35:27 UTC Build successful.

github-actions · 2024-09-02T18:25:39Z

⚪ 2024-09-02 18:25:38 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5aba053 has started.
⚪ 2024-09-02 18:29:44 UTC ya make is running...
⚫ 2024-09-02 18:36:23 UTC Check cancelled

github-actions · 2024-09-02T18:25:45Z

⚪ 2024-09-02 18:25:45 UTC Pre-commit check linux-x86_64-release-asan for 5aba053 has started.
⚪ 2024-09-02 18:28:39 UTC ya make is running...
⚫ 2024-09-02 18:36:24 UTC Check cancelled

github-actions · 2024-09-02T18:37:53Z

⚪ 2024-09-02 18:37:52 UTC Pre-commit check linux-x86_64-release-clang14 for 4836ece has started.
⚪ 2024-09-02 18:40:53 UTC ya make is running...
⚫ 2024-09-02 18:42:18 UTC Check cancelled

github-actions · 2024-09-02T18:39:25Z

⚪ 2024-09-02 18:39:25 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4836ece has started.
⚫ 2024-09-02 18:42:18 UTC Check cancelled

github-actions · 2024-09-02T18:39:56Z

⚪ 2024-09-02 18:39:55 UTC Pre-commit check linux-x86_64-release-asan for 4836ece has started.
⚫ 2024-09-02 18:42:22 UTC Check cancelled

github-actions · 2024-09-02T18:43:48Z

⚪ 2024-09-02 18:43:48 UTC Pre-commit check linux-x86_64-release-clang14 for ef96b4d has started.
⚪ 2024-09-02 18:46:34 UTC ya make is running...
🟢 2024-09-02 18:54:56 UTC Build successful.

github-actions · 2024-09-02T18:43:49Z

⚪ 2024-09-02 18:43:48 UTC Pre-commit check linux-x86_64-release-asan for ef96b4d has started.
⚪ 2024-09-02 18:46:37 UTC ya make is running...
🔴 2024-09-02 20:21:12 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
11321	11254	0	19	28	20

🟢 2024-09-02 20:22:11 UTC Build successful.
🟢 2024-09-02 20:22:39 UTC ydbd size 5.5 GiB changed* by +40.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `30edde3`	merge: `ef96b4d`	diff	diff %
ydbd size	5 954 099 208 Bytes	5 954 140 704 Bytes	+40.5 KiB	+0.001%
ydbd stripped size	1 489 367 472 Bytes	1 489 375 216 Bytes	+7.6 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-09-02T18:43:49Z

⚪ 2024-09-02 18:43:49 UTC Pre-commit check linux-x86_64-relwithdebinfo for ef96b4d has started.
⚪ 2024-09-02 18:46:49 UTC ya make is running...
🟡 2024-09-02 19:50:06 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15741	14343	0	15	1362	21

⚪ 2024-09-02 19:51:26 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-02 20:01:35 UTC Tests successful.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
38 (only retried tests)	24	0	0	0	14

🟢 2024-09-02 20:01:42 UTC Build successful.
🟢 2024-09-02 20:02:19 UTC ydbd size 8.3 GiB changed* by +56.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `30edde3`	merge: `ef96b4d`	diff	diff %
ydbd size	8 917 939 256 Bytes	8 917 997 344 Bytes	+56.7 KiB	+0.001%
ydbd stripped size	481 779 208 Bytes	481 781 896 Bytes	+2.6 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

maximyurchuk · 2024-09-02T20:41:21Z

library/cpp/bucket_quoter/bucket_quoter.h

@@ -2,9 +2,9 @@

 #include <library/cpp/deprecated/atomic/atomic.h>


library синкается из Аркадии: надо там поправить и потом сделать синк (можно мне написать по синку)

Править эту директорию на гитхабе -- некорректно

github-actions · 2024-09-06T09:07:32Z

⚪ 2024-09-06 09:07:32 UTC Pre-commit check linux-x86_64-release-clang14 for 025bf18 has started.

github-actions · 2024-09-06T09:07:39Z

⚪ 2024-09-06 09:07:38 UTC Pre-commit check linux-x86_64-relwithdebinfo for 025bf18 has started.

github-actions · 2024-09-06T09:08:29Z

⚪ 2024-09-06 09:08:29 UTC Pre-commit check linux-x86_64-release-asan for 025bf18 has started.

github-actions · 2024-09-06T12:54:07Z

⚪ 2024-09-06 12:54:07 UTC Pre-commit check linux-x86_64-release-asan for 048a486 has started.

github-actions · 2024-09-06T13:11:29Z

⚪ 2024-09-06 13:11:28 UTC Pre-commit check linux-x86_64-relwithdebinfo for 048a486 has started.

github-actions · 2024-09-06T13:12:47Z

⚪ 2024-09-06 13:12:46 UTC Pre-commit check linux-x86_64-release-clang14 for 048a486 has started.

github-actions · 2024-09-09T08:59:11Z

⚪ 2024-09-09 08:59:10 UTC Pre-commit check linux-x86_64-release-clang14 for de733d0 has started.
🔴 2024-09-09 09:00:57 UTC Graph compare failed, see the logs.

github-actions · 2024-09-09T08:59:31Z

⚪ 2024-09-09 08:59:30 UTC Pre-commit check linux-x86_64-release-asan for de733d0 has started.
🔴 2024-09-09 09:01:23 UTC Graph compare failed, see the logs.

github-actions · 2024-09-09T09:01:03Z

⚪ 2024-09-09 09:01:02 UTC Pre-commit check linux-x86_64-relwithdebinfo for de733d0 has started.
🔴 2024-09-09 09:02:52 UTC Graph compare failed, see the logs.

github-actions · 2024-09-09T10:34:57Z

⚪ 2024-09-09 10:34:56 UTC Pre-commit check linux-x86_64-release-clang14 for 08e83e4 has started.
⚪ 2024-09-09 10:39:03 UTC ya make is running...
🟢 2024-09-09 10:49:08 UTC Build successful.

github-actions · 2024-09-09T10:36:18Z

⚪ 2024-09-09 10:36:17 UTC Pre-commit check linux-x86_64-release-asan for 08e83e4 has started.
⚪ 2024-09-09 10:39:09 UTC ya make is running...
🔴 2024-09-09 12:17:44 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
11336	11264	0	23	22	27

🟢 2024-09-09 12:18:46 UTC Build successful.
🟢 2024-09-09 12:19:19 UTC ydbd size 5.6 GiB changed* by +40.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `b440d31`	merge: `08e83e4`	diff	diff %
ydbd size	6 032 161 600 Bytes	6 032 203 152 Bytes	+40.6 KiB	+0.001%
ydbd stripped size	1 510 169 648 Bytes	1 510 177 392 Bytes	+7.6 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-09-09T10:36:53Z

⚪ 2024-09-09 10:36:52 UTC Pre-commit check linux-x86_64-relwithdebinfo for 08e83e4 has started.
⚪ 2024-09-09 10:39:51 UTC ya make is running...
🟡 2024-09-09 11:49:42 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15970	14559	0	9	1371	31

⚪ 2024-09-09 11:51:02 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-09-09 12:07:48 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
50 (only retried tests)	27	0	5	1	17

⚪ 2024-09-09 12:07:56 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-09-09 12:15:10 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
27 (only retried tests)	6	0	4	0	17

🟢 2024-09-09 12:15:17 UTC Build successful.
🟢 2024-09-09 12:15:56 UTC ydbd size 8.4 GiB changed* by +56.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `b440d31`	merge: `08e83e4`	diff	diff %
ydbd size	9 017 352 288 Bytes	9 017 410 096 Bytes	+56.5 KiB	+0.001%
ydbd stripped size	487 429 128 Bytes	487 431 752 Bytes	+2.6 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

serbel324 requested a review from a team as a code owner September 2, 2024 18:19

github-actions bot added the new-feature label Sep 2, 2024

github-actions bot added improvement and removed new-feature labels Sep 2, 2024

serbel324 force-pushed the bs/vdisk/better-bucket branch from d97b9f8 to 54ccf61 Compare September 2, 2024 18:22

Use lock-free Bucket in CostTracker with limited underflow

20fad85

Remove unused methods

d55376f

serbel324 force-pushed the bs/vdisk/better-bucket branch from 54ccf61 to d55376f Compare September 2, 2024 18:35

Small refactoring

75833b6

maximyurchuk reviewed Sep 2, 2024

View reviewed changes

serbel324 force-pushed the bs/vdisk/better-bucket branch from 8e80a4d to 6117a84 Compare September 6, 2024 09:05

Move lockfree bucket to ydb/library

fdef532

serbel324 force-pushed the bs/vdisk/better-bucket branch from 6117a84 to fdef532 Compare September 6, 2024 12:40

Fix build

2e87b50

serbel324 force-pushed the bs/vdisk/better-bucket branch from 97bac42 to 2e87b50 Compare September 9, 2024 10:33

alexvru approved these changes Sep 9, 2024

View reviewed changes

maximyurchuk merged commit d22f086 into ydb-platform:main Sep 9, 2024
7 of 12 checks passed

This was referenced Sep 10, 2024

YQ kqprun fixed AS pools and added validations #9030

Merged

YQ-3653 added resource pools classifiers validations #9037

Merged

shnikd mentioned this pull request Sep 11, 2024

Long name domain test #9096

Closed

StekPerepolnen mentioned this pull request Sep 17, 2024

doc hc api images source #9376

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use lock-free Bucket in CostTracker with limited underflow #8637

Use lock-free Bucket in CostTracker with limited underflow #8637

serbel324 commented Sep 2, 2024 •

edited

Loading

github-actions bot commented Sep 2, 2024 •

edited

Loading

github-actions bot commented Sep 2, 2024 •

edited

Loading

github-actions bot commented Sep 2, 2024 •

edited

Loading

github-actions bot commented Sep 2, 2024 •

edited

Loading

github-actions bot commented Sep 2, 2024 •

edited

Loading

github-actions bot commented Sep 2, 2024 •

edited

Loading

github-actions bot commented Sep 2, 2024 •

edited

Loading

github-actions bot commented Sep 2, 2024 •

edited

Loading

github-actions bot commented Sep 2, 2024 •

edited

Loading

github-actions bot commented Sep 2, 2024 •

edited

Loading

maximyurchuk Sep 2, 2024 •

edited

Loading

github-actions bot commented Sep 6, 2024

github-actions bot commented Sep 6, 2024

github-actions bot commented Sep 6, 2024

github-actions bot commented Sep 6, 2024

github-actions bot commented Sep 6, 2024

github-actions bot commented Sep 6, 2024

github-actions bot commented Sep 9, 2024 •

edited

Loading

github-actions bot commented Sep 9, 2024 •

edited

Loading

github-actions bot commented Sep 9, 2024 •

edited

Loading

github-actions bot commented Sep 9, 2024 •

edited

Loading

github-actions bot commented Sep 9, 2024 •

edited

Loading

github-actions bot commented Sep 9, 2024 •

edited

Loading

		@@ -2,9 +2,9 @@

		#include <library/cpp/deprecated/atomic/atomic.h>

Use lock-free Bucket in CostTracker with limited underflow #8637

Use lock-free Bucket in CostTracker with limited underflow #8637

Conversation

serbel324 commented Sep 2, 2024 • edited Loading

Changelog entry

Changelog category

Additional information

github-actions bot commented Sep 2, 2024 • edited Loading

github-actions bot commented Sep 2, 2024 • edited Loading

github-actions bot commented Sep 2, 2024 • edited Loading

github-actions bot commented Sep 2, 2024 • edited Loading

github-actions bot commented Sep 2, 2024 • edited Loading

github-actions bot commented Sep 2, 2024 • edited Loading

github-actions bot commented Sep 2, 2024 • edited Loading

github-actions bot commented Sep 2, 2024 • edited Loading

github-actions bot commented Sep 2, 2024 • edited Loading

github-actions bot commented Sep 2, 2024 • edited Loading

maximyurchuk Sep 2, 2024 • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Sep 6, 2024

github-actions bot commented Sep 6, 2024

github-actions bot commented Sep 6, 2024

github-actions bot commented Sep 6, 2024

github-actions bot commented Sep 6, 2024

github-actions bot commented Sep 6, 2024

github-actions bot commented Sep 9, 2024 • edited Loading

github-actions bot commented Sep 9, 2024 • edited Loading

github-actions bot commented Sep 9, 2024 • edited Loading

github-actions bot commented Sep 9, 2024 • edited Loading

github-actions bot commented Sep 9, 2024 • edited Loading

github-actions bot commented Sep 9, 2024 • edited Loading

serbel324 commented Sep 2, 2024 •

edited

Loading

github-actions bot commented Sep 2, 2024 •

edited

Loading

github-actions bot commented Sep 2, 2024 •

edited

Loading

github-actions bot commented Sep 2, 2024 •

edited

Loading

github-actions bot commented Sep 2, 2024 •

edited

Loading

github-actions bot commented Sep 2, 2024 •

edited

Loading

github-actions bot commented Sep 2, 2024 •

edited

Loading

github-actions bot commented Sep 2, 2024 •

edited

Loading

github-actions bot commented Sep 2, 2024 •

edited

Loading

github-actions bot commented Sep 2, 2024 •

edited

Loading

github-actions bot commented Sep 2, 2024 •

edited

Loading

maximyurchuk Sep 2, 2024 •

edited

Loading

github-actions bot commented Sep 9, 2024 •

edited

Loading

github-actions bot commented Sep 9, 2024 •

edited

Loading

github-actions bot commented Sep 9, 2024 •

edited

Loading

github-actions bot commented Sep 9, 2024 •

edited

Loading

github-actions bot commented Sep 9, 2024 •

edited

Loading

github-actions bot commented Sep 9, 2024 •

edited

Loading