Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pushdown non-separable filters over Aggregate #8468

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Pushdown non-separable filters over Aggregate #8468

merged 2 commits into from
Aug 29, 2024

Conversation

nepal
Copy link
Collaborator

@nepal nepal commented Aug 29, 2024

Changelog entry

  • Pushdown non-separable filters over Aggregate

Changelog category

  • New feature
  • Experimental feature
  • Performance improvement
  • Not for changelog (changelog entry is not required)

Additional information

...

@nepal nepal requested a review from a team as a code owner August 29, 2024 12:06
@nepal nepal added the area/yql YQL query language issues label Aug 29, 2024
@nepal nepal requested a review from vitstn August 29, 2024 12:22
nepal
nepal commented Aug 29, 2024
View reviewed changes
ydb/library/yql/core/common_opt/yql_co_flow2.cpp
!AllOf(usedFields, [&](TStringBuf field) { return keyColumns.contains(field); }) ||
!IsStrict(p))
!p->IsComplete() && !IsStrict(p))
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Пушдаунить константные не-стрикт предикаты можно. А недетерминированные - нельзя (HasDependsOn)

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 29, 2024 •
edited
Loading

⚪ 2024-08-29 12:28:55 UTC Pre-commit check linux-x86_64-release-clang14 for 90b5216 has started.
⚪ 2024-08-29 12:31:44 UTC ya make is running...
🟢 2024-08-29 12:38:24 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 29, 2024 •
edited
Loading

⚪ 2024-08-29 12:37:21 UTC Pre-commit check linux-x86_64-relwithdebinfo for 90b5216 has started.
⚪ 2024-08-29 12:40:06 UTC ya make is running...
🟡 2024-08-29 13:53:35 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
72977 59198 0 58 13704 17

⚪ 2024-08-29 14:00:40 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-08-29 14:10:48 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
86 (only retried tests) 68 0 6 0 12

⚪ 2024-08-29 14:10:57 UTC ya make is running... (failed tests rerun, try 3)
🟢 2024-08-29 14:18:27 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
23 (only retried tests) 11 0 0 0 12

🟢 2024-08-29 14:18:35 UTC Build successful.
🟡 2024-08-29 14:19:14 UTC ydbd size 8.2 GiB changed* by +690.5 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 1e1d882 merge: 90b5216 diff diff %
ydbd size 8 818 402 248 Bytes 8 819 109 312 Bytes +690.5 KiB +0.008%
ydbd stripped size 480 776 840 Bytes 480 796 552 Bytes +19.2 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 29, 2024 •
edited
Loading

⚪ 2024-08-29 12:47:54 UTC Pre-commit check linux-x86_64-release-asan for 90b5216 has started.
⚪ 2024-08-29 12:51:43 UTC ya make is running...
🔴 2024-08-29 14:18:55 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10862 10782 0 21 38 21

🟢 2024-08-29 14:19:52 UTC Build successful.
🟡 2024-08-29 14:20:21 UTC ydbd size 5.5 GiB changed* by +323.5 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 1e1d882 merge: 90b5216 diff diff %
ydbd size 5 942 606 472 Bytes 5 942 937 728 Bytes +323.5 KiB +0.006%
ydbd stripped size 1 492 419 568 Bytes 1 492 510 832 Bytes +89.1 KiB +0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 29, 2024 •
edited
Loading

⚪ 2024-08-29 18:39:05 UTC Pre-commit check linux-x86_64-release-clang14 for 8092de2 has started.
⚪ 2024-08-29 18:42:09 UTC ya make is running...
🟢 2024-08-29 19:02:48 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 29, 2024 •
edited
Loading

⚪ 2024-08-29 18:39:24 UTC Pre-commit check linux-x86_64-release-asan for 8092de2 has started.
⚪ 2024-08-29 18:43:11 UTC ya make is running...
🔴 2024-08-29 20:24:02 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13758 13687 0 17 36 18

🟢 2024-08-29 20:25:13 UTC Build successful.
🟡 2024-08-29 20:25:43 UTC ydbd size 5.5 GiB changed* by +321.5 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: e2dfc63 merge: 8092de2 diff diff %
ydbd size 5 944 651 952 Bytes 5 944 981 216 Bytes +321.5 KiB +0.006%
ydbd stripped size 1 492 786 576 Bytes 1 492 875 792 Bytes +87.1 KiB +0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 29, 2024 •
edited
Loading

⚪ 2024-08-29 18:39:26 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8092de2 has started.
⚪ 2024-08-29 18:42:30 UTC ya make is running...
🟡 2024-08-29 20:13:17 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
75890 62153 0 9 13704 24

⚪ 2024-08-29 20:20:35 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-08-29 20:29:40 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39 (only retried tests) 24 0 1 0 14

⚪ 2024-08-29 20:29:49 UTC ya make is running... (failed tests rerun, try 3)
🟢 2024-08-29 20:38:35 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20 (only retried tests) 8 0 0 0 12

🟢 2024-08-29 20:38:42 UTC Build successful.
🟡 2024-08-29 20:39:24 UTC ydbd size 8.2 GiB changed* by +702.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: e2dfc63 merge: 8092de2 diff diff %
ydbd size 8 819 847 680 Bytes 8 820 567 384 Bytes +702.8 KiB +0.008%
ydbd stripped size 480 853 512 Bytes 480 878 728 Bytes +24.6 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nepal nepal merged commit df3f77e into ydb-platform:main Aug 29, 2024
10 of 12 checks passed
@nepal nepal deleted the yql-18408-pushdown-over-agg branch August 29, 2024 20:47
@siarheivesialou siarheivesialou mentioned this pull request Aug 30, 2024
Merged
stanislav-shchetinin pushed a commit to stanislav-shchetinin/ydb that referenced this pull request Aug 30, 2024
@nepal @stanislav-shchetinin
Pushdown non-separable filters over Aggregate (ydb-platform#8468)
865622f
@siarheivesialou siarheivesialou mentioned this pull request Sep 4, 2024
Merged
This was referenced Sep 4, 2024
Merged
Merged
Merged
This was referenced Sep 9, 2024
Merged
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Sep 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitstn vitstn vitstn approved these changes

Assignees
No one assigned
Labels
area/yql YQL query language issues new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nepal @vitstn