Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary message #8219

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

MBkkt
Copy link
Collaborator

@MBkkt MBkkt commented Aug 23, 2024

ACCEPTED is unnecessary, because

  1. if schemeshard doesn't restart, it doesn't change anything from schemeshard/datashard point of view
  2. if schemeshard restart, it's same because we anyway restart scan for this shard from scratch, so there won't be any difference

@MBkkt MBkkt requested a review from ijon August 23, 2024 14:51
Copy link

github-actions bot commented Aug 23, 2024

2024-08-23 14:52:00 UTC Pre-commit check for da48852 has started.
2024-08-23 14:54:55 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-23 15:53:58 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14547 13175 0 7 1349 16

2024-08-23 15:55:11 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-23 16:02:38 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27 (only retried tests) 18 0 0 0 9

🟢 2024-08-23 16:02:45 UTC Build successful.
🟡 2024-08-23 16:03:19 UTC ydbd size 8.2 GiB changed* by +271.5 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 6cd8814 merge: da48852 diff diff %
ydbd size 8 760 671 008 Bytes 8 760 949 024 Bytes +271.5 KiB +0.003%
ydbd stripped size 478 027 400 Bytes 478 046 792 Bytes +18.9 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 23, 2024

2024-08-23 14:52:51 UTC Pre-commit check for da48852 has started.
2024-08-23 14:55:41 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-23 15:01:16 UTC Build successful.

Copy link

github-actions bot commented Aug 23, 2024

2024-08-23 14:54:47 UTC Pre-commit check for da48852 has started.
2024-08-23 14:57:28 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-23 16:21:59 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9959 9900 0 13 28 18

🟢 2024-08-23 16:22:54 UTC Build successful.
🟢 2024-08-23 16:23:23 UTC ydbd size 5.5 GiB changed* by -18.5 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: f2f6db7 merge: da48852 diff diff %
ydbd size 5 896 700 600 Bytes 5 896 681 640 Bytes -18.5 KiB -0.000%
ydbd stripped size 1 481 889 616 Bytes 1 481 885 584 Bytes -3.9 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@MBkkt MBkkt self-assigned this Aug 26, 2024
@ijon ijon requested a review from CyberROFL August 28, 2024 16:10
@ijon
Copy link
Collaborator

ijon commented Aug 28, 2024

@CyberROFL take a look, please

ijon
ijon previously approved these changes Aug 28, 2024
Copy link

github-actions bot commented Sep 6, 2024

2024-09-06 05:41:23 UTC Pre-commit check linux-x86_64-release-clang14 for a48dc2e has started.

Copy link

github-actions bot commented Sep 6, 2024

2024-09-06 05:41:26 UTC Pre-commit check linux-x86_64-release-asan for a48dc2e has started.

Copy link

github-actions bot commented Sep 6, 2024

2024-09-06 05:41:30 UTC Pre-commit check linux-x86_64-relwithdebinfo for a48dc2e has started.

@MBkkt MBkkt added the rebase-and-check Rebase PR with the current base branch and check label Sep 6, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Sep 6, 2024
Copy link

github-actions bot commented Sep 6, 2024

2024-09-06 09:23:18 UTC Pre-commit check linux-x86_64-release-asan for 81bf53d has started.
2024-09-06 09:26:31 UTC ya make is running...
🔴 2024-09-06 11:38:25 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11523 11447 0 22 25 29

🟢 2024-09-06 11:39:26 UTC Build successful.
🟢 2024-09-06 11:40:00 UTC ydbd size 5.6 GiB changed* by -13.6 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 83c2452 merge: 81bf53d diff diff %
ydbd size 6 028 915 152 Bytes 6 028 901 184 Bytes -13.6 KiB -0.000%
ydbd stripped size 1 509 646 192 Bytes 1 509 643 440 Bytes -2.7 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 6, 2024

2024-09-06 09:24:57 UTC Pre-commit check linux-x86_64-release-clang14 for 81bf53d has started.
2024-09-06 09:28:08 UTC ya make is running...
🟢 2024-09-06 10:15:51 UTC Build successful.

Copy link

github-actions bot commented Sep 6, 2024

2024-09-06 09:25:45 UTC Pre-commit check linux-x86_64-relwithdebinfo for 81bf53d has started.
2024-09-06 09:28:57 UTC ya make is running...
🟡 2024-09-06 11:16:53 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40788 35329 0 15 5419 25

2024-09-06 11:20:25 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-06 11:28:00 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
53 (only retried tests) 34 0 0 1 18

🟢 2024-09-06 11:28:07 UTC Build successful.
🟢 2024-09-06 11:28:46 UTC ydbd size 8.4 GiB changed* by -6.0 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 83c2452 merge: 81bf53d diff diff %
ydbd size 9 013 279 424 Bytes 9 013 273 288 Bytes -6.0 KiB -0.000%
ydbd stripped size 487 289 608 Bytes 487 289 224 Bytes -384 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@MBkkt MBkkt merged commit 221f25a into ydb-platform:main Sep 6, 2024
12 of 17 checks passed
@shnikd shnikd mentioned this pull request Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants