Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24-3: Fix unexpected read iterator stream reset #7710

Merged

Conversation

snaury
Copy link
Member

@snaury snaury commented Aug 13, 2024

Changelog entry

Fixed an issue where a SELECT query could produce unexpected duplicate rows.

Changelog category

  • Bugfix

Additional information

Fixes #7674.

Copy link

github-actions bot commented Aug 13, 2024

2024-08-13 10:38:37 UTC Pre-commit check for 83603dc has started.
2024-08-13 10:41:12 UTC Build linux-x86_64-release-asan is running...
🟢 2024-08-13 11:06:43 UTC Build successful.
2024-08-13 11:06:58 UTC Tests are running...
🔴 2024-08-13 12:59:19 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9817 9771 0 8 25 13

🟢 2024-08-13 12:59:56 UTC ydbd size 5.5 GiB changed* by +87.3 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: c85f845 merge: 83603dc diff diff %
ydbd size 5 904 321 312 Bytes 5 904 410 696 Bytes +87.3 KiB +0.002%
ydbd stripped size 1 480 255 616 Bytes 1 480 272 000 Bytes +16.0 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 13, 2024

2024-08-13 10:40:44 UTC Pre-commit check for 83603dc has started.
2024-08-13 10:43:20 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-08-13 11:23:33 UTC Build successful.
2024-08-13 11:23:49 UTC Tests are running...
🔴 2024-08-13 12:47:33 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14117 12804 0 5 1299 9

🟢 2024-08-13 12:48:32 UTC ydbd size 8.1 GiB changed* by +73.5 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: 282df40 merge: 83603dc diff diff %
ydbd size 8 723 846 368 Bytes 8 723 921 616 Bytes +73.5 KiB +0.001%
ydbd stripped size 476 904 968 Bytes 476 913 352 Bytes +8.2 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 13, 2024

2024-08-13 10:41:20 UTC Pre-commit check for 83603dc has started.
2024-08-13 10:44:19 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-08-13 10:51:40 UTC Build successful.

@snaury snaury marked this pull request as ready for review August 13, 2024 11:18
@snaury snaury requested a review from a team as a code owner August 13, 2024 11:18
@snaury snaury merged commit b12cda0 into ydb-platform:stable-24-3 Aug 13, 2024
8 of 12 checks passed
@snaury snaury deleted the fix-7674-last-key-reset-24-3 branch August 13, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants