Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unexpected read iterator stream reset #7697

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

snaury
Copy link
Member

@snaury snaury commented Aug 13, 2024

Changelog entry

Fixed an issue where a SELECT query could produce unexpected duplicate rows.

Changelog category

  • Bugfix

Additional information

Fixes #7674.

Copy link

github-actions bot commented Aug 13, 2024

2024-08-13 09:00:03 UTC Pre-commit check for 4066f94 has started.
2024-08-13 09:02:56 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-13 09:12:08 UTC Build successful.

Copy link

github-actions bot commented Aug 13, 2024

2024-08-13 09:00:38 UTC Pre-commit check for 4066f94 has started.
2024-08-13 09:04:41 UTC Check linux-x86_64-relwithdebinfo is running...
🟢 2024-08-13 10:38:00 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14089 12740 0 0 1335 14

🟢 2024-08-13 10:39:35 UTC Build successful.
🟢 2024-08-13 10:40:09 UTC ydbd size 8.1 GiB changed* by +63.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 5ccb818 merge: 4066f94 diff diff %
ydbd size 8 700 411 808 Bytes 8 700 476 360 Bytes +63.0 KiB +0.001%
ydbd stripped size 473 084 488 Bytes 473 089 288 Bytes +4.7 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 13, 2024

2024-08-13 09:02:20 UTC Pre-commit check for 4066f94 has started.
2024-08-13 09:05:24 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-13 11:08:36 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9751 9711 0 7 22 11

🟢 2024-08-13 11:09:44 UTC Build successful.
🟢 2024-08-13 11:10:13 UTC ydbd size 5.4 GiB changed* by +91.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 5ccb818 merge: 4066f94 diff diff %
ydbd size 5 851 252 280 Bytes 5 851 346 016 Bytes +91.5 KiB +0.002%
ydbd stripped size 1 469 332 688 Bytes 1 469 353 488 Bytes +20.3 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@snaury snaury merged commit 2e43e2a into ydb-platform:main Aug 13, 2024
11 of 13 checks passed
@snaury snaury deleted the fix-7674-last-key-reset branch August 13, 2024 11:17
naspirato pushed a commit to naspirato/ydb that referenced this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataShard: read iterators quota bug and unexpected stream resets
3 participants