Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore stored GCBarrierPreparation #7473

Merged
merged 4 commits into from
Aug 5, 2024
Merged

Ignore stored GCBarrierPreparation #7473

merged 4 commits into from
Aug 5, 2024

Conversation

zverevgeny
Copy link
Collaborator

Changelog category

  • Bugfix

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024 •
edited
Loading

⚪ 2024-08-05 16:18:27 UTC Pre-commit check for 7bd6d5f has started.
⚪ 2024-08-05 16:20:58 UTC Build linux-x86_64-release-asan is running...
⚫ 2024-08-05 16:26:21 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024 •
edited
Loading

⚪ 2024-08-05 16:20:19 UTC Pre-commit check for 7bd6d5f has started.
⚪ 2024-08-05 16:22:52 UTC Build linux-x86_64-relwithdebinfo is running...
⚫ 2024-08-05 16:24:41 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024 •
edited
Loading

⚪ 2024-08-05 16:20:25 UTC Pre-commit check for 7bd6d5f has started.
⚪ 2024-08-05 16:22:56 UTC Build linux-x86_64-release-clang14 is running...
⚫ 2024-08-05 16:24:47 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024 •
edited
Loading

⚪ 2024-08-05 16:28:40 UTC Pre-commit check for 3f5550a has started.
⚪ 2024-08-05 16:31:39 UTC Build linux-x86_64-release-clang14 is running...
⚫ 2024-08-05 16:37:43 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024 •
edited
Loading

⚪ 2024-08-05 16:29:09 UTC Pre-commit check for 3f5550a has started.
⚪ 2024-08-05 16:31:39 UTC Build linux-x86_64-release-asan is running...
⚫ 2024-08-05 16:38:08 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024 •
edited
Loading

⚪ 2024-08-05 16:30:02 UTC Pre-commit check for 3f5550a has started.
⚪ 2024-08-05 16:32:38 UTC Build linux-x86_64-relwithdebinfo is running...
⚫ 2024-08-05 16:37:47 UTC Check cancelled

@zverevgeny zverevgeny linked an issue Aug 5, 2024 that may be closed by this pull request
CS fails on 24-3-4 #7468
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024 •
edited
Loading

⚪ 2024-08-05 16:42:39 UTC Pre-commit check for 3497b1b has started.
⚪ 2024-08-05 16:45:17 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-08-05 16:50:54 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024 •
edited
Loading

⚪ 2024-08-05 16:42:40 UTC Pre-commit check for 3497b1b has started.
⚪ 2024-08-05 16:45:10 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-08-05 17:23:08 UTC Build successful.
⚪ 2024-08-05 17:23:25 UTC Tests are running...
🟢 2024-08-05 18:44:39 UTC Tests successful.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13872 12553 0 0 1306 13

🟢 2024-08-05 18:45:23 UTC ydbd size 8.1 GiB changed* by +12.4 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: 3fb7fa2 merge: 3497b1b diff diff %
ydbd size 8 721 930 968 Bytes 8 721 943 616 Bytes +12.4 KiB +0.000%
ydbd stripped size 476 888 072 Bytes 476 888 776 Bytes +704 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024 •
edited
Loading

⚪ 2024-08-05 16:45:24 UTC Pre-commit check for 3497b1b has started.
⚪ 2024-08-05 16:48:00 UTC Build linux-x86_64-release-asan is running...
🟢 2024-08-05 17:10:41 UTC Build successful.
⚪ 2024-08-05 17:15:56 UTC Tests are running...
🔴 2024-08-05 19:11:48 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9736 9686 0 11 25 14

🟢 2024-08-05 19:12:29 UTC ydbd size 5.5 GiB changed* by +11.4 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: 3fb7fa2 merge: 3497b1b diff diff %
ydbd size 5 903 484 856 Bytes 5 903 496 536 Bytes +11.4 KiB +0.000%
ydbd stripped size 1 480 181 600 Bytes 1 480 184 160 Bytes +2.5 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@zverevgeny zverevgeny marked this pull request as ready for review August 5, 2024 17:58
@zverevgeny zverevgeny requested a review from a team as a code owner August 5, 2024 17:58
@zverevgeny zverevgeny merged commit ccf98e2 into ydb-platform:stable-24-3 Aug 5, 2024
10 of 12 checks passed
@niksaveliev niksaveliev mentioned this pull request Aug 15, 2024
Closed
This was referenced Aug 16, 2024
Closed
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Aug 23, 2024
Closed
@siarheivesialou siarheivesialou mentioned this pull request Aug 28, 2024
Closed
@swalrus1 swalrus1 mentioned this pull request Sep 3, 2024
Closed
zverevgeny added a commit to zverevgeny/ydb that referenced this pull request Sep 15, 2024
@zverevgeny
Revert "Ignore stored GCBarrierPreparation (ydb-platform#7473)"
c583feb 
This reverts commit ccf98e2.
zverevgeny added a commit to zverevgeny/ydb that referenced this pull request Sep 15, 2024
@zverevgeny
Revert "Ignore stored GCBarrierPreparation (ydb-platform#7473)"
2ad4a75 
This reverts commit ccf98e2.
@StekPerepolnen StekPerepolnen mentioned this pull request Oct 29, 2024
Closed
@StekPerepolnen StekPerepolnen mentioned this pull request Oct 29, 2024
Closed
@serbel324 serbel324 mentioned this pull request Nov 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fomichev3000 fomichev3000 fomichev3000 approved these changes

@ivanmorozov333 ivanmorozov333 ivanmorozov333 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CS fails on 24-3-4
3 participants
@zverevgeny @fomichev3000 @ivanmorozov333