Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PushLeftStage fix #7270

Merged
merged 2 commits into from
Jul 31, 2024
Merged

PushLeftStage fix #7270

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e20d8d
Initial commit
shnikd Jul 30, 2024
6bc2fc8
Fixes
shnikd Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ydb/core/kqp/opt/physical/kqp_opt_phy.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,7 @@ class TKqpPhysicalOptTransformer : public TOptimizeTransformerBase {
{
// TODO: Allow push to left stage for data queries.
// It is now possible as we don't use datashard transactions for reads in data queries.
bool pushLeftStage = !KqpCtx.IsDataQuery() && AllowFuseJoinInputs(node);
bool pushLeftStage = (KqpCtx.IsScanQuery() || KqpCtx.Config->EnableKqpScanQueryStreamIdxLookupJoin) && AllowFuseJoinInputs(node);
shnikd marked this conversation as resolved.
Show resolved Hide resolved
TExprBase output = DqBuildJoin(node, ctx, optCtx, *getParents(), IsGlobal,
pushLeftStage, KqpCtx.Config->GetHashJoinMode(), false
);
Expand Down
Loading