Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session actor perf #724

Merged
merged 6 commits into from
Dec 27, 2023

Conversation

nikvas0
Copy link
Collaborator

@nikvas0 nikvas0 commented Dec 26, 2023

No description provided.

Copy link

github-actions bot commented Dec 26, 2023

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 7a2b260.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
59414 50235 0 13 9138 28

🟢 linux-x86_64-release-asan: all tests PASSED for commit 7a2b260.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

gridnevvvit
gridnevvvit previously approved these changes Dec 26, 2023
@gridnevvvit
Copy link
Member

gridnevvvit commented Dec 26, 2023

[[bad]]assertion failed at ydb/core/kqp/ut/tx/kqp_tx_ut.cpp:433, virtual void NKikimr::NKqp::NTestSuiteKqpTx::TTestCaseRollbackByIdle::Execute_(NUnitTest::TTestContext &): (!commitResult.IsSuccess()) [[rst]]
[[alt1]]0. /home/runner/actions_runner/_work/ydb/ydb/library/cpp/testing/unittest/registar.cpp:47: NUnitTest::NPrivate::RaiseError @ 0x1447FACB

  1. /-S/ydb/core/kqp/ut/tx/kqp_tx_ut.cpp:433: NKikimr::NKqp::NTestSuiteKqpTx::TTestCaseRollbackByIdle::Execute_ @ 0x13F95E0C
  2. /-S/ydb/core/kqp/ut/tx/kqp_tx_ut.cpp:11: NKikimr::NKqp::NTestSuiteKqpTx::TCurrentTest::Execute()::(anonymous class)::operator() @ 0x13FECA28

It looks like test is failing after this commit. It's possibly a flaky test but we need to be sure about this.
test: ydb/core/kqp/ut/tx/KqpTx.RollbackByIdle

@gridnevvvit gridnevvvit dismissed their stale review December 26, 2023 16:24

need to check tests

@nikvas0 nikvas0 merged commit a196e8b into ydb-platform:main Dec 27, 2023
2 of 4 checks passed
nikvas0 added a commit that referenced this pull request Dec 28, 2023
nikvas0 added a commit that referenced this pull request Dec 28, 2023
@jepett0 jepett0 mentioned this pull request Dec 28, 2023
@StekPerepolnen StekPerepolnen mentioned this pull request Dec 29, 2023
Closed
adameat pushed a commit to adameat/ydb that referenced this pull request Dec 29, 2023
adameat pushed a commit to adameat/ydb that referenced this pull request Dec 29, 2023
This was referenced Jan 3, 2024
@vitstn vitstn mentioned this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants