Dont create delete flags column if not necessary #7169

zverevgeny · 2024-07-28T13:47:36Z

Integrate this PR #7082 plus required refactoring made before it

After this change CS will create new column DELETE_FLAG when the first DELETE operation is executed. Currently it creates this column at startup, that make database incompatible with the previous version.

github-actions · 2024-07-28T13:49:17Z

⚪ 2024-07-28 13:49:17 UTC Pre-commit check for 8432391 has started.
⚪ 2024-07-28 13:52:03 UTC Build linux-x86_64-release-asan is running...
🔴 2024-07-28 13:54:45 UTC Build failed. see the build logs.
🔴 2024-07-28 13:54:46 UTC Tests run skipped.

github-actions · 2024-07-28T13:51:10Z

⚪ 2024-07-28 13:51:10 UTC Pre-commit check for 8432391 has started.
⚪ 2024-07-28 13:53:57 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-07-28 13:57:06 UTC Build failed. see the build logs.

github-actions · 2024-07-28T13:51:13Z

⚪ 2024-07-28 13:51:13 UTC Pre-commit check for 8432391 has started.
⚪ 2024-07-28 13:54:09 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-07-28 13:57:05 UTC Build failed. see the build logs.
🔴 2024-07-28 13:57:06 UTC Tests run skipped.

github-actions · 2024-07-28T14:38:29Z

⚪ 2024-07-28 14:38:29 UTC Pre-commit check for fe9225e has started.
⚪ 2024-07-28 14:41:51 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-28 15:17:33 UTC Build successful.

github-actions · 2024-07-28T14:40:03Z

⚪ 2024-07-28 14:40:03 UTC Pre-commit check for fe9225e has started.
⚪ 2024-07-28 14:42:52 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-28 15:24:22 UTC Build successful.
⚪ 2024-07-28 15:24:39 UTC Tests are running...
🔴 2024-07-28 17:26:11 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
11247	10667	0	84	321	175

🟡 2024-07-28 17:27:01 UTC ydbd size 5.2 GiB changed* by +556.7 KiB, which is >= 100.0 KiB vs stable-24-3: Warning

ydbd size dash	stable-24-3: `a196e19`	merge: `fe9225e`	diff	diff %
ydbd size	5 612 291 120 Bytes	5 612 861 168 Bytes	+556.7 KiB	+0.010%
ydbd stripped size	1 210 289 544 Bytes	1 210 185 640 Bytes	-101.5 KiB	-0.009%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-07-28T14:40:16Z

⚪ 2024-07-28 14:40:15 UTC Pre-commit check for fe9225e has started.
⚪ 2024-07-28 14:43:04 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-28 15:45:37 UTC Build successful.
⚪ 2024-07-28 15:45:56 UTC Tests are running...
🔴 2024-07-28 17:30:34 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
39767	34529	0	2	5221	15

🟡 2024-07-28 17:31:18 UTC ydbd size 8.1 GiB changed* by +1.9 MiB, which is >= 100.0 KiB vs stable-24-3: Warning

ydbd size dash	stable-24-3: `a196e19`	merge: `fe9225e`	diff	diff %
ydbd size	8 721 536 544 Bytes	8 723 501 104 Bytes	+1.9 MiB	+0.023%
ydbd stripped size	476 948 488 Bytes	476 904 456 Bytes	-43.0 KiB	-0.009%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-07-28T18:45:35Z

⚪ 2024-07-28 18:45:34 UTC Pre-commit check for fe9225e has started.
⚪ 2024-07-28 18:48:22 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-28 18:53:54 UTC Build successful.

github-actions · 2024-07-28T18:45:41Z

⚪ 2024-07-28 18:45:41 UTC Pre-commit check for fe9225e has started.
⚪ 2024-07-28 18:48:38 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-28 19:12:16 UTC Build successful.
⚪ 2024-07-28 19:12:34 UTC Tests are running...
🔴 2024-07-28 21:22:02 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
11250	10665	0	85	324	176

🟡 2024-07-28 21:22:56 UTC ydbd size 5.2 GiB changed* by +556.7 KiB, which is >= 100.0 KiB vs stable-24-3: Warning

ydbd size dash	stable-24-3: `a196e19`	merge: `fe9225e`	diff	diff %
ydbd size	5 612 291 120 Bytes	5 612 861 168 Bytes	+556.7 KiB	+0.010%
ydbd stripped size	1 210 289 544 Bytes	1 210 185 640 Bytes	-101.5 KiB	-0.009%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-07-28T18:45:47Z

⚪ 2024-07-28 18:45:46 UTC Pre-commit check for fe9225e has started.
⚪ 2024-07-28 18:48:44 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-28 19:27:05 UTC Build successful.
⚪ 2024-07-28 19:27:23 UTC Tests are running...
🔴 2024-07-28 21:16:29 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
39764	34526	0	2	5221	15

🟡 2024-07-28 21:17:16 UTC ydbd size 8.1 GiB changed* by +1.9 MiB, which is >= 100.0 KiB vs stable-24-3: Warning

ydbd size dash	stable-24-3: `a196e19`	merge: `fe9225e`	diff	diff %
ydbd size	8 721 536 544 Bytes	8 723 501 104 Bytes	+1.9 MiB	+0.023%
ydbd stripped size	476 948 488 Bytes	476 904 456 Bytes	-43.0 KiB	-0.009%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

ivanmorozov333 added 5 commits July 28, 2024 16:40

Refactoring use general container (ydb-platform#6836)

dce2849

Skip default columns on indexation (ydb-platform#6899)

49b97ab

unify indexation (for committed data) and compaction (ydb-platform#6909)

4a1c75c

separate merger logic for make new one (ydb-platform#6931)

c67e3c2

dont create delete flag column in indexation (ydb-platform#7082)

5219891

zverevgeny linked an issue Jul 28, 2024 that may be closed by this pull request

CS fails when downgrade from 24.3 to 24.2 #7049

Closed

fix unused

bc40abd

zverevgeny added the rebase-and-check Rebase PR with the current base branch and check label Jul 28, 2024

github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Jul 28, 2024

zverevgeny marked this pull request as ready for review July 29, 2024 04:55

zverevgeny requested a review from a team as a code owner July 29, 2024 04:55

fomichev3000 approved these changes Jul 29, 2024

View reviewed changes

zverevgeny merged commit e8f2390 into ydb-platform:stable-24-3 Jul 29, 2024
11 of 17 checks passed

niksaveliev mentioned this pull request Aug 15, 2024

New kafka metering fix #7856

Closed

This was referenced Aug 16, 2024

Fix use after move in http_proxy #7884

Closed

fix use after move in http_proxy #7885

Merged

StekPerepolnen mentioned this pull request Aug 23, 2024

merge/stable 24 3/query float test asan #8192

Closed

siarheivesialou mentioned this pull request Aug 28, 2024

stable 24 3 6 logbroker add 5 last requests #8389

Closed

swalrus1 mentioned this pull request Sep 3, 2024

Update stable-24-3: add metrics to describe table #8688

Closed

This was referenced Oct 29, 2024

viewer healthcheck pathmerge stable 24 3 11 hotfix #11042

Closed

viewer healthcheck pathmerge stable 24 #11044

Closed

serbel324 mentioned this pull request Nov 19, 2024

Merge double accelerations into 24-3 #11740

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dont create delete flags column if not necessary #7169

Dont create delete flags column if not necessary #7169

zverevgeny commented Jul 28, 2024 •

edited

Loading

github-actions bot commented Jul 28, 2024 •

edited

Loading

github-actions bot commented Jul 28, 2024 •

edited

Loading

github-actions bot commented Jul 28, 2024 •

edited

Loading

github-actions bot commented Jul 28, 2024 •

edited

Loading

github-actions bot commented Jul 28, 2024 •

edited

Loading

github-actions bot commented Jul 28, 2024 •

edited

Loading

github-actions bot commented Jul 28, 2024 •

edited

Loading

github-actions bot commented Jul 28, 2024 •

edited

Loading

github-actions bot commented Jul 28, 2024 •

edited

Loading

Dont create delete flags column if not necessary #7169

Dont create delete flags column if not necessary #7169

Conversation

zverevgeny commented Jul 28, 2024 • edited Loading

github-actions bot commented Jul 28, 2024 • edited Loading

github-actions bot commented Jul 28, 2024 • edited Loading

github-actions bot commented Jul 28, 2024 • edited Loading

github-actions bot commented Jul 28, 2024 • edited Loading

github-actions bot commented Jul 28, 2024 • edited Loading

github-actions bot commented Jul 28, 2024 • edited Loading

github-actions bot commented Jul 28, 2024 • edited Loading

github-actions bot commented Jul 28, 2024 • edited Loading

github-actions bot commented Jul 28, 2024 • edited Loading

zverevgeny commented Jul 28, 2024 •

edited

Loading

github-actions bot commented Jul 28, 2024 •

edited

Loading

github-actions bot commented Jul 28, 2024 •

edited

Loading

github-actions bot commented Jul 28, 2024 •

edited

Loading

github-actions bot commented Jul 28, 2024 •

edited

Loading

github-actions bot commented Jul 28, 2024 •

edited

Loading

github-actions bot commented Jul 28, 2024 •

edited

Loading

github-actions bot commented Jul 28, 2024 •

edited

Loading

github-actions bot commented Jul 28, 2024 •

edited

Loading

github-actions bot commented Jul 28, 2024 •

edited

Loading