Keep Issue fields after censorship #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note This is an automated comment that will be appended during run. 🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 4a9591e.
🔴 linux-x86_64-release-asan: some tests FAILED for commit 4a9591e.
|
dorooleg
reviewed
Dec 26, 2023
| @@ -50,7 +50,8 @@ class TIssueDatabaseRemover { | |||
|
|
|||
| TIntrusivePtr<NYql::TIssue> Run(const NYql::TIssue& issue) { | |||
| auto msg = RemoveDatabaseFromStr(issue.GetMessage(), DatabasePath); | |||
| auto newIssue = MakeIntrusive<NYql::TIssue>(msg); | |||
| auto newIssue = MakeIntrusive<NYql::TIssue>(issue.Position, issue.EndPosition, msg); | |||
There was a problem hiding this comment.
Could we add the test here. We can change this field at https://a.yandex-team.ru/arcadia/ydb/tests/tools/fq_runner/kikimr_runner.py?rev=13154375#L379 to BM_DROP_WITH_WARNING in any existing test and check that the we don't any have problems in this case
MetaGigachad
approved these changes
Dec 26, 2023
dorooleg
approved these changes
Dec 26, 2023
This was referenced Dec 28, 2023
This was referenced Dec 29, 2023
Closed
adameat
pushed a commit
to adameat/ydb
that referenced
this pull request
Dec 29, 2023
* Keep Issue fields after censorship * Tests
This was referenced Jan 15, 2024
Merged
This was referenced Jan 31, 2024
This was referenced Feb 1, 2024
This was referenced Feb 1, 2024
Merged
Merged
This was referenced Feb 5, 2024
This was referenced Feb 5, 2024
Merged
Merged
Merged
Merged
This was referenced Feb 8, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.