Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont create delete flag column in indexation #7082

Merged
merged 7 commits into from
Jul 26, 2024
Merged

dont create delete flag column in indexation #7082

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c94e8b1
dont create delete flag column in indexation
ivanmorozov333 Jul 25, 2024
96778b4
fix
ivanmorozov333 Jul 25, 2024
7373848
fix
ivanmorozov333 Jul 25, 2024
c8b77a8
fix
ivanmorozov333 Jul 26, 2024
7b3e845
improve and fix test
ivanmorozov333 Jul 26, 2024
bbc0cd0
fix test
ivanmorozov333 Jul 26, 2024
3bc5ebc
fix test
ivanmorozov333 Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions ydb/core/tx/columnshard/engines/changes/indexation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,9 @@ TConclusionStatus TInsertColumnEngineChanges::DoConstructBlobs(TConstructionCont
auto blobSchema = context.SchemaVersions.GetSchemaVerified(inserted.GetSchemaVersion());
std::vector<ui32> filteredIds = inserted.GetMeta().GetSchemaSubset().Apply(blobSchema->GetIndexInfo().GetColumnIds(true));
usageColumnIds.insert(filteredIds.begin(), filteredIds.end());
if (inserted.GetMeta().GetModificationType() == NEvWrite::EModificationType::Delete) {
usageColumnIds.emplace((ui32)IIndexInfo::ESpecialColumn::DELETE_FLAG);
}
if (usageColumnIds.size() == resultSchema->GetIndexInfo().GetColumnIds(true).size()) {
break;
}
Expand All @@ -179,8 +182,10 @@ TConclusionStatus TInsertColumnEngineChanges::DoConstructBlobs(TConstructionCont
}

IIndexInfo::AddSnapshotColumns(*batch, inserted.GetSnapshot());
IIndexInfo::AddDeleteFlagsColumn(*batch, inserted.GetMeta().GetModificationType() == NEvWrite::EModificationType::Delete);
usageColumnIds.insert(IIndexInfo::GetSystemColumnIds().begin(), IIndexInfo::GetSystemColumnIds().end());
if (usageColumnIds.contains((ui32)IIndexInfo::ESpecialColumn::DELETE_FLAG)) {
IIndexInfo::AddDeleteFlagsColumn(*batch, inserted.GetMeta().GetModificationType() == NEvWrite::EModificationType::Delete);
}
usageColumnIds.insert(IIndexInfo::GetSnapshotColumnIds().begin(), IIndexInfo::GetSnapshotColumnIds().end());

batch = resultSchema->NormalizeBatch(*blobSchema, batch, usageColumnIds).DetachResult();
pathBatches.Add(inserted, shardingFilterCommit, batch);
Expand Down
Loading