Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WideCombiner with spilling better buffer pass #7022

Merged
merged 5 commits into from
Jul 25, 2024
Merged

WideCombiner with spilling better buffer pass #7022

merged 5 commits into from
Jul 25, 2024

Conversation

lll-phill-lll
Copy link
Member

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@lll-phill-lll lll-phill-lll requested a review from a team as a code owner July 23, 2024 19:50
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 23, 2024 •
edited
Loading

⚪ 2024-07-23 19:53:46 UTC Pre-commit check for e66697f has started.
⚪ 2024-07-23 19:56:34 UTC Build+Tests linux-x86_64-release-clang14 is running...
🔴 2024-07-23 19:59:33 UTC Build failed. see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 23, 2024 •
edited
Loading

⚪ 2024-07-23 19:54:25 UTC Pre-commit check for e66697f has started.
⚪ 2024-07-23 19:57:14 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🔴 2024-07-23 20:01:33 UTC Build failed. see the logs.
🔴 2024-07-23 20:01:36 UTC Test run completed, no test results found for commit 390ef80.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 23, 2024 •
edited
Loading

⚪ 2024-07-23 19:54:37 UTC Pre-commit check for e66697f has started.
⚪ 2024-07-23 19:57:22 UTC Build+Tests linux-x86_64-release-asan is running...
🔴 2024-07-23 20:00:45 UTC Build failed. see the logs.
🔴 2024-07-23 20:00:48 UTC Test run completed, no test results found for commit 390ef80.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

⚪ 2024-07-24 11:48:56 UTC Pre-commit check for 344e824 has started.
⚪ 2024-07-24 11:51:47 UTC Check linux-x86_64-relwithdebinfo is running...
⚫ 2024-07-24 11:54:12 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

⚪ 2024-07-24 11:49:00 UTC Pre-commit check for 344e824 has started.
⚪ 2024-07-24 11:51:54 UTC Check linux-x86_64-release-asan is running...
⚫ 2024-07-24 11:54:15 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

⚪ 2024-07-24 11:49:03 UTC Pre-commit check for 344e824 has started.
⚪ 2024-07-24 11:52:06 UTC Check linux-x86_64-release-clang14 is running...
⚫ 2024-07-24 11:54:12 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

⚪ 2024-07-24 11:55:47 UTC Pre-commit check for 57e5ffd has started.
⚪ 2024-07-24 11:58:32 UTC Check linux-x86_64-release-asan is running...
⚫ 2024-07-24 12:02:30 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

⚪ 2024-07-24 11:55:55 UTC Pre-commit check for 57e5ffd has started.
⚪ 2024-07-24 11:58:42 UTC Check linux-x86_64-relwithdebinfo is running...
⚫ 2024-07-24 12:02:22 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

⚪ 2024-07-24 11:58:03 UTC Pre-commit check for 57e5ffd has started.
⚪ 2024-07-24 12:00:56 UTC Check linux-x86_64-release-clang14 is running...
⚫ 2024-07-24 12:02:18 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

⚪ 2024-07-24 12:03:58 UTC Pre-commit check for 02fabf0 has started.
⚪ 2024-07-24 12:06:57 UTC Check linux-x86_64-relwithdebinfo is running...
⚫ 2024-07-24 13:56:33 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

⚪ 2024-07-24 12:03:58 UTC Pre-commit check for 02fabf0 has started.
⚪ 2024-07-24 12:06:53 UTC Check linux-x86_64-release-asan is running...
⚫ 2024-07-24 13:56:32 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

⚪ 2024-07-24 12:06:22 UTC Pre-commit check for 02fabf0 has started.
⚪ 2024-07-24 12:09:13 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-07-24 12:46:56 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

⚪ 2024-07-24 14:00:10 UTC Pre-commit check for 2a9c7e7 has started.
⚪ 2024-07-24 14:03:03 UTC Check linux-x86_64-relwithdebinfo is running...
🔴 2024-07-24 16:14:20 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
73366 59807 0 2 13547 10

⚪ 2024-07-24 16:23:08 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-07-24 16:31:01 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12 (only retried tests) 4 0 0 1 7

🟢 2024-07-24 16:38:59 UTC Build successful.
🟢 2024-07-24 16:39:41 UTC ydbd size 8.1 GiB changed* by -1.4 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 006fe83 merge: 2a9c7e7 diff diff %
ydbd size 8 655 416 496 Bytes 8 655 415 048 Bytes -1.4 KiB -0.000%
ydbd stripped size 471 212 288 Bytes 471 212 416 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

⚪ 2024-07-24 14:00:28 UTC Pre-commit check for 2a9c7e7 has started.
⚪ 2024-07-24 14:03:22 UTC Check linux-x86_64-release-asan is running...
🔴 2024-07-24 16:13:06 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11996 11400 0 89 334 173

🟢 2024-07-24 16:14:19 UTC Build successful.
🟢 2024-07-24 16:15:06 UTC ydbd size 5.2 GiB changed* by +144 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 006fe83 merge: 2a9c7e7 diff diff %
ydbd size 5 558 078 952 Bytes 5 558 079 096 Bytes +144 Bytes +0.000%
ydbd stripped size 1 197 262 512 Bytes 1 197 262 576 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

⚪ 2024-07-24 14:00:31 UTC Pre-commit check for 2a9c7e7 has started.
⚪ 2024-07-24 14:04:15 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-07-24 14:10:49 UTC Build successful.

@lll-phill-lll lll-phill-lll merged commit 833f929 into ydb-platform:main Jul 25, 2024
10 of 12 checks passed
lll-phill-lll added a commit to lll-phill-lll/ydb that referenced this pull request Sep 9, 2024
@lll-phill-lll
WideCombiner with spilling better buffer pass (ydb-platform#7022)
0b3868f
lll-phill-lll added a commit to lll-phill-lll/ydb that referenced this pull request Sep 10, 2024
@lll-phill-lll
WideCombiner with spilling better buffer pass (ydb-platform#7022)
2f44529
lll-phill-lll added a commit to lll-phill-lll/ydb that referenced this pull request Sep 11, 2024
@lll-phill-lll
WideCombiner with spilling better buffer pass (ydb-platform#7022)
69a91af
lll-phill-lll added a commit that referenced this pull request Sep 12, 2024
@lll-phill-lll
WideCombiner with spilling better buffer pass (#7022)
7fc1c53
lll-phill-lll added a commit to lll-phill-lll/ydb that referenced this pull request Sep 13, 2024
@lll-phill-lll
WideCombiner with spilling better buffer pass (ydb-platform#7022)
5515a3a
lll-phill-lll added a commit to lll-phill-lll/ydb that referenced this pull request Sep 13, 2024
@lll-phill-lll
WideCombiner with spilling better buffer pass (ydb-platform#7022)
27b14dd
lll-phill-lll added a commit to lll-phill-lll/ydb that referenced this pull request Sep 15, 2024
@lll-phill-lll
WideCombiner with spilling better buffer pass (ydb-platform#7022)
ff2dc74
lll-phill-lll added a commit to lll-phill-lll/ydb that referenced this pull request Sep 15, 2024
@lll-phill-lll
WideCombiner with spilling better buffer pass (ydb-platform#7022)
cb9f7f3
@lll-phill-lll lll-phill-lll mentioned this pull request Sep 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darych Darych Darych approved these changes

@Tony-Romanov Tony-Romanov Tony-Romanov approved these changes

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lll-phill-lll @Darych @Tony-Romanov