-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add kafka-api global version #702
Conversation
Jornydb
commented
Dec 25, 2023
- [docs] Add kafka-api global version
✅ Documentation buildRevision builded successful |
@@ -0,0 +1,9 @@ | |||
The Kafka protocol version 3.4.0 is supported with limitations: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing title
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing title
✅
@@ -0,0 +1,9 @@ | |||
The Kafka protocol version 3.4.0 is supported with limitations: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's better to use the same terminology in filename and text (limitations vs constraints)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's better to use the same terminology in filename and text (limitations vs constraints)
✅
|
||
### Writing via Kafka Java SDK | ||
|
||
This example includes a code snippet for writing data to a topic via Kafka Java SDK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a full version of this with imports, main function definition, etc.? a link to something like this would have been useful
Co-authored-by: Ivan Blinkov <ivan@blinkov.ru>
✅ Documentation buildRevision builded successful |
✅ Documentation buildRevision builded successful |
✅ Documentation buildRevision builded successful |
✅ Documentation buildRevision builded successful |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just fix list order.
✅ Documentation buildRevision builded successful |