Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add kafka-api global version #702

Merged
merged 8 commits into from
Jan 16, 2024
Merged

Conversation

Jornydb
Copy link
Contributor

@Jornydb Jornydb commented Dec 25, 2023

  • [docs] Add kafka-api global version

Copy link

✅ Documentation build

Revision builded successful
Revision preview link

@@ -0,0 +1,9 @@
The Kafka protocol version 3.4.0 is supported with limitations:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing title

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing title

@@ -0,0 +1,9 @@
The Kafka protocol version 3.4.0 is supported with limitations:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's better to use the same terminology in filename and text (limitations vs constraints)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's better to use the same terminology in filename and text (limitations vs constraints)


### Writing via Kafka Java SDK

This example includes a code snippet for writing data to a topic via Kafka Java SDK.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a full version of this with imports, main function definition, etc.? a link to something like this would have been useful

Co-authored-by: Ivan Blinkov <ivan@blinkov.ru>
Copy link

✅ Documentation build

Revision builded successful
Revision preview link

Copy link

✅ Documentation build

Revision builded successful
Revision preview link

@Jornydb Jornydb requested a review from a team as a code owner January 15, 2024 12:26
Copy link

✅ Documentation build

Revision builded successful
Revision preview link

Copy link

✅ Documentation build

Revision builded successful
Revision preview link

Copy link
Member

@fomichev3000 fomichev3000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just fix list order.

Copy link

✅ Documentation build

Revision builded successful
Revision preview link

@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
@vitstn vitstn mentioned this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants