Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add feature flag to enable spilling nodes #6895

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

gridnevvvit
Copy link
Member

Changelog entry

allow enabling spilling for compute nodes

Changelog category

  • Improvement

Additional information

...

Copy link

github-actions bot commented Jul 19, 2024

2024-07-19 19:47:21 UTC Pre-commit check for d2d1fec has started.
2024-07-19 19:50:15 UTC Build+Tests linux-x86_64-release-clang14 is running...
2024-07-19 19:54:59 UTC Check cancelled

Copy link

github-actions bot commented Jul 19, 2024

2024-07-19 19:47:27 UTC Pre-commit check for d2d1fec has started.
2024-07-19 19:50:22 UTC Build+Tests linux-x86_64-release-asan is running...
🔴 2024-07-19 19:54:52 UTC Test run completed, no test results found for commit cffa237.
2024-07-19 19:55:13 UTC Check cancelled

Copy link

github-actions bot commented Jul 19, 2024

2024-07-19 19:47:30 UTC Pre-commit check for d2d1fec has started.
2024-07-19 19:50:51 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🔴 2024-07-19 19:54:52 UTC Test run completed, no test results found for commit cffa237.
2024-07-19 19:55:09 UTC Check cancelled

@gridnevvvit gridnevvvit force-pushed the spilling-nodes-support branch from cffa237 to 77d293a Compare July 19, 2024 19:54
Copy link

github-actions bot commented Jul 19, 2024

2024-07-19 19:56:35 UTC Pre-commit check for d466d70 has started.
2024-07-19 19:59:30 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🟢 2024-07-19 22:10:10 UTC Build successful.
🔴 2024-07-19 22:14:23 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39594 34358 0 2 5224 10

🔴 2024-07-19 22:15:03 UTC ydbd size 8.1 GiB changed* by +13.4 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: 19153a4 merge: d466d70 diff diff %
ydbd size 8 641 993 624 Bytes 8 656 018 592 Bytes +13.4 MiB +0.162%
ydbd stripped size 470 492 384 Bytes 471 109 376 Bytes +602.5 KiB +0.131%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 19, 2024

2024-07-19 19:56:36 UTC Pre-commit check for d466d70 has started.
2024-07-19 19:59:51 UTC Build+Tests linux-x86_64-release-clang14 is running...
🟢 2024-07-19 20:41:31 UTC Build successful.

Copy link

github-actions bot commented Jul 19, 2024

2024-07-19 19:56:41 UTC Pre-commit check for d466d70 has started.
2024-07-19 19:59:40 UTC Build+Tests linux-x86_64-release-asan is running...
🟢 2024-07-19 22:29:27 UTC Build successful.
🔴 2024-07-19 22:32:30 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11060 10458 0 99 329 174

🔴 2024-07-19 22:33:19 UTC ydbd size 5.2 GiB changed* by +8.6 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: 19153a4 merge: d466d70 diff diff %
ydbd size 5 546 451 224 Bytes 5 555 494 064 Bytes +8.6 MiB +0.163%
ydbd stripped size 1 195 225 712 Bytes 1 196 918 416 Bytes +1.6 MiB +0.142%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@gridnevvvit gridnevvvit force-pushed the spilling-nodes-support branch from 77d293a to 645cbdf Compare July 25, 2024 22:17
@gridnevvvit gridnevvvit requested review from a team as code owners July 25, 2024 22:17
@gridnevvvit gridnevvvit force-pushed the spilling-nodes-support branch from 645cbdf to ba7574e Compare July 25, 2024 22:22
@gridnevvvit gridnevvvit removed the request for review from a team July 25, 2024 22:23
Copy link

github-actions bot commented Jul 25, 2024

2024-07-25 22:27:26 UTC Pre-commit check for 9ace5ee has started.
2024-07-25 22:30:48 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-07-26 00:34:41 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39771 34480 0 5 5274 12

2024-07-26 00:38:39 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-07-26 00:46:45 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16 (only retried tests) 7 0 0 1 8

🟢 2024-07-26 00:50:04 UTC Build successful.
🟢 2024-07-26 00:50:43 UTC ydbd size 8.1 GiB changed* by +12.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 34b6297 merge: 9ace5ee diff diff %
ydbd size 8 667 429 864 Bytes 8 667 442 400 Bytes +12.2 KiB +0.000%
ydbd stripped size 471 525 696 Bytes 471 530 336 Bytes +4.5 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 25, 2024

2024-07-25 22:35:22 UTC Pre-commit check for 9ace5ee has started.
2024-07-25 22:38:26 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-07-25 23:10:35 UTC Build successful.

Copy link

github-actions bot commented Jul 25, 2024

2024-07-25 22:57:50 UTC Pre-commit check for 9ace5ee has started.
2024-07-25 23:01:41 UTC Check linux-x86_64-release-asan is running...
🔴 2024-07-26 01:39:22 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11089 10495 0 89 331 174

🟢 2024-07-26 01:40:26 UTC Build successful.
🟢 2024-07-26 01:41:30 UTC ydbd size 5.2 GiB changed* by +20.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 34b6297 merge: 9ace5ee diff diff %
ydbd size 5 564 663 224 Bytes 5 564 683 952 Bytes +20.2 KiB +0.000%
ydbd stripped size 1 198 266 832 Bytes 1 198 268 240 Bytes +1.4 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@gridnevvvit gridnevvvit merged commit 7cf9db7 into ydb-platform:main Jul 26, 2024
10 of 12 checks passed
@gridnevvvit gridnevvvit deleted the spilling-nodes-support branch July 26, 2024 09:58
lll-phill-lll pushed a commit to lll-phill-lll/ydb that referenced this pull request Sep 9, 2024
lll-phill-lll pushed a commit to lll-phill-lll/ydb that referenced this pull request Sep 10, 2024
lll-phill-lll pushed a commit to lll-phill-lll/ydb that referenced this pull request Sep 11, 2024
lll-phill-lll pushed a commit to lll-phill-lll/ydb that referenced this pull request Sep 13, 2024
lll-phill-lll pushed a commit to lll-phill-lll/ydb that referenced this pull request Sep 13, 2024
lll-phill-lll pushed a commit to lll-phill-lll/ydb that referenced this pull request Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants