Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprioritise system tablets in balancer #6840

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

vporyadke
Copy link
Collaborator

Changelog entry

make less coordinator&mediator moves

Changelog category

  • Performance improvement

Additional information

...

Copy link

github-actions bot commented Jul 18, 2024

2024-07-18 16:30:54 UTC Pre-commit check for 065e373 has started.
2024-07-18 16:33:51 UTC Build+Tests linux-x86_64-release-clang14 is running...
🟢 2024-07-18 17:07:24 UTC Build successful.

Copy link

github-actions bot commented Jul 18, 2024

2024-07-18 16:30:54 UTC Pre-commit check for 065e373 has started.
2024-07-18 16:33:49 UTC Build+Tests linux-x86_64-release-asan is running...
🟢 2024-07-18 19:01:32 UTC Build successful.
🔴 2024-07-18 19:03:30 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11029 10438 0 96 323 172

🟢 2024-07-18 19:04:15 UTC ydbd size 5.2 GiB changed* by +16.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: d1fc6c4 merge: 065e373 diff diff %
ydbd size 5 546 630 944 Bytes 5 546 647 296 Bytes +16.0 KiB +0.000%
ydbd stripped size 1 195 268 144 Bytes 1 195 271 088 Bytes +2.9 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 18, 2024

2024-07-18 16:31:20 UTC Pre-commit check for 065e373 has started.
2024-07-18 16:34:22 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🟢 2024-07-18 18:51:48 UTC Build successful.
🔴 2024-07-18 18:56:09 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39559 34314 0 7 5222 16

🟢 2024-07-18 18:56:54 UTC ydbd size 8.0 GiB changed* by +19.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: d1fc6c4 merge: 065e373 diff diff %
ydbd size 8 642 072 136 Bytes 8 642 092 200 Bytes +19.6 KiB +0.000%
ydbd stripped size 470 505 760 Bytes 470 506 848 Bytes +1.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@@ -62,17 +62,17 @@ void BalanceNodes<NKikimrConfig::THiveConfig::HIVE_NODE_BALANCE_STRATEGY_RANDOM>
}

template<>
void BalanceTablets<NKikimrConfig::THiveConfig::HIVE_TABLET_BALANCE_STRATEGY_OLD_WEIGHTED_RANDOM>(std::vector<TTabletInfo*>& tablets, EResourceToBalance resourceToBalance) {
void BalanceTablets<NKikimrConfig::THiveConfig::HIVE_TABLET_BALANCE_STRATEGY_OLD_WEIGHTED_RANDOM>(std::vector<TTabletInfo*>::iterator first, std::vector<TTabletInfo*>::iterator last, EResourceToBalance resourceToBalance) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would advise of not using first-last semantics, where it's clear that it's a begin-end semantics.
the key difference is that "last" usually points to existing element, while "end" points to the position, after the last element

@vporyadke vporyadke merged commit 31f281f into ydb-platform:main Jul 23, 2024
9 of 13 checks passed
vporyadke added a commit to vporyadke/ydb that referenced this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants