Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YQL-17286: Fix sublink in projection, which has no external deps #684

Merged
merged 2 commits into from
Dec 27, 2023

Conversation

marsaly79
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Dec 22, 2023

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-release-asan: some tests FAILED for commit e866d0c.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15290 15136 0 22 113 19

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit e866d0c.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
59142 49944 0 8 9173 17

@marsaly79 marsaly79 force-pushed the fix-sublink-without-ext-deps branch from a01e281 to e866d0c Compare December 26, 2023 17:27
@marsaly79 marsaly79 requested a review from vitstn December 26, 2023 17:30
@marsaly79 marsaly79 marked this pull request as draft December 26, 2023 17:30
@vitstn
Copy link
Collaborator

vitstn commented Dec 26, 2023

непонятно с тестами

ydb/library/yql/tests/sql/dq_file/part0/pytest | 0.000s | FAIL |  
ydb/library/yql/tests/sql/sql2yql/py3test | 0.000s | FAIL |  
ydb/library/yql/tests/sql/yt_native_file/part0/pytest | 0.000s | FAIL

@marsaly79 marsaly79 marked this pull request as ready for review December 26, 2023 19:24
@marsaly79
Copy link
Collaborator Author

непонятно с тестами

ydb/library/yql/tests/sql/dq_file/part0/pytest | 0.000s | FAIL | ydb/library/yql/tests/sql/sql2yql/py3test | 0.000s | FAIL | ydb/library/yql/tests/sql/yt_native_file/part0/pytest | 0.000s | FAIL

Это предыдущий прогон, я там синк канондаты из MDS не сделал. В новом прогоне тесты прошли

@marsaly79 marsaly79 merged commit cba9d6a into ydb-platform:main Dec 27, 2023
2 of 4 checks passed
@marsaly79 marsaly79 deleted the fix-sublink-without-ext-deps branch December 27, 2023 09:49
@jepett0 jepett0 mentioned this pull request Dec 28, 2023
@StekPerepolnen StekPerepolnen mentioned this pull request Dec 29, 2023
Closed
adameat pushed a commit to adameat/ydb that referenced this pull request Dec 29, 2023
This was referenced Jan 3, 2024
This was referenced Jan 11, 2024
@vitstn vitstn mentioned this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants