Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TEventSimple #6715

Merged
merged 4 commits into from
Jul 16, 2024
Merged

Conversation

maximyurchuk
Copy link
Collaborator

Changelog entry

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

Copy link

github-actions bot commented Jul 15, 2024

2024-07-15 22:57:11 UTC Pre-commit check for 9cdd16a has started.
2024-07-15 23:00:21 UTC Build+Tests linux-x86_64-release-asan is running...
🟢 2024-07-16 01:45:20 UTC Build successful.
🔴 2024-07-16 01:49:03 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13487 12883 0 87 339 178

🟢 2024-07-16 01:49:47 UTC ydbd size 5.2 GiB changed* by +616 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 2cb5973 merge: 9cdd16a diff diff %
ydbd size 5 569 081 152 Bytes 5 569 081 768 Bytes +616 Bytes +0.000%
ydbd stripped size 1 201 132 400 Bytes 1 201 132 848 Bytes +448 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 15, 2024

2024-07-15 22:57:18 UTC Pre-commit check for 9cdd16a has started.
2024-07-15 23:00:22 UTC Build+Tests linux-x86_64-release-clang14 is running...
🟢 2024-07-15 23:43:40 UTC Build successful.

Copy link

github-actions bot commented Jul 15, 2024

2024-07-15 22:57:23 UTC Pre-commit check for 9cdd16a has started.
2024-07-15 23:00:33 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🟢 2024-07-16 01:42:10 UTC Build successful.
🔴 2024-07-16 01:53:15 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
74609 61154 0 6 13431 18

🟢 2024-07-16 01:53:55 UTC ydbd size 8.1 GiB changed* by -2.0 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 2cb5973 merge: 9cdd16a diff diff %
ydbd size 8 682 836 728 Bytes 8 682 834 688 Bytes -2.0 KiB -0.000%
ydbd stripped size 473 942 624 Bytes 473 942 560 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@maximyurchuk maximyurchuk marked this pull request as ready for review July 16, 2024 07:08
@@ -281,14 +281,14 @@ class TDataReq : public TActor<TDataReq> {

struct TEvPrivate {
enum EEv {
EvProxyDataReqOngoingTransactionsWatchdog = EventSpaceBegin(TEvents::ES_PRIVATE),
TEvProxyDataReqOngoingTransactionsWatchdog = EventSpaceBegin(TEvents::ES_PRIVATE),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing Transactions was added

Copy link

github-actions bot commented Jul 16, 2024

2024-07-16 09:37:13 UTC Pre-commit check for 8aa2ee7 has started.
2024-07-16 09:40:04 UTC Check cancelled

Copy link

github-actions bot commented Jul 16, 2024

2024-07-16 09:55:50 UTC Pre-commit check for c3a253b has started.
2024-07-16 09:59:29 UTC Build+Tests linux-x86_64-release-clang14 is running...
🟢 2024-07-16 10:37:15 UTC Build successful.

Copy link

github-actions bot commented Jul 16, 2024

2024-07-16 10:07:01 UTC Pre-commit check for c3a253b has started.
2024-07-16 10:10:49 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🟢 2024-07-16 12:54:26 UTC Build successful.
🔴 2024-07-16 13:06:02 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
74620 61161 0 10 13431 18

🟢 2024-07-16 13:06:51 UTC ydbd size 8.0 GiB changed* by +38.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 457b2b4 merge: c3a253b diff diff %
ydbd size 8 642 821 000 Bytes 8 642 859 864 Bytes +38.0 KiB +0.000%
ydbd stripped size 470 528 448 Bytes 470 530 496 Bytes +2.0 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 16, 2024

2024-07-16 10:17:16 UTC Pre-commit check for c3a253b has started.
2024-07-16 10:20:22 UTC Build+Tests linux-x86_64-release-asan is running...
🟢 2024-07-16 12:56:48 UTC Build successful.
🔴 2024-07-16 12:59:49 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13467 12861 0 90 334 182

🟢 2024-07-16 13:00:36 UTC ydbd size 5.2 GiB changed* by +24.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 457b2b4 merge: c3a253b diff diff %
ydbd size 5 548 952 816 Bytes 5 548 977 976 Bytes +24.6 KiB +0.000%
ydbd stripped size 1 194 957 904 Bytes 1 194 962 096 Bytes +4.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants