Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unsafe append to tablecell #6696

Conversation

Enjection
Copy link
Member

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

Copy link

github-actions bot commented Jul 15, 2024

2024-07-15 13:47:18 UTC Pre-commit check for 65aa553 has started.
2024-07-15 13:50:14 UTC Build+Tests linux-x86_64-release-asan is running...
🔴 2024-07-15 14:16:54 UTC Test run completed, no test results found for commit 2cc063e.
2024-07-15 14:17:21 UTC Check cancelled

Copy link

github-actions bot commented Jul 15, 2024

2024-07-15 13:47:23 UTC Pre-commit check for 65aa553 has started.
2024-07-15 13:50:22 UTC Build+Tests linux-x86_64-release-clang14 is running...
2024-07-15 14:17:01 UTC Check cancelled

Copy link

github-actions bot commented Jul 15, 2024

2024-07-15 13:50:07 UTC Pre-commit check for 65aa553 has started.
2024-07-15 13:53:10 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🔴 2024-07-15 14:16:42 UTC Test run completed, no test results found for commit 2cc063e.
2024-07-15 14:17:05 UTC Check cancelled

CyberROFL
CyberROFL previously approved these changes Jul 15, 2024
Copy link
Member

@CyberROFL CyberROFL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, но пусть еще @snaury посмотрит.

@CyberROFL CyberROFL requested a review from snaury July 15, 2024 13:59
ydb/core/scheme/scheme_tablecell.cpp Outdated Show resolved Hide resolved
ydb/core/scheme/scheme_tablecell.cpp Outdated Show resolved Hide resolved
snaury
snaury previously approved these changes Jul 15, 2024
ydb/core/scheme/scheme_tablecell.cpp Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Jul 15, 2024

2024-07-15 14:28:23 UTC Pre-commit check for 1a2f9d6 has started.
2024-07-15 14:31:42 UTC Build+Tests linux-x86_64-release-clang14 is running...
2024-07-15 14:38:31 UTC Check cancelled

Copy link

github-actions bot commented Jul 15, 2024

2024-07-15 14:42:06 UTC Pre-commit check for f724910 has started.
2024-07-15 14:45:03 UTC Build+Tests linux-x86_64-release-clang14 is running...
🟢 2024-07-15 14:56:15 UTC Build successful.

Copy link

github-actions bot commented Jul 15, 2024

2024-07-15 14:48:44 UTC Pre-commit check for f724910 has started.
2024-07-15 14:52:06 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🟢 2024-07-15 16:48:12 UTC Build successful.
🔴 2024-07-15 16:55:02 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39436 34183 0 11 5221 21

🟢 2024-07-15 16:55:42 UTC ydbd size 8.1 GiB changed* by -7.8 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 85d4495 merge: f724910 diff diff %
ydbd size 8 691 124 032 Bytes 8 682 924 432 Bytes -7.8 MiB -0.094%
ydbd stripped size 473 665 904 Bytes 473 245 296 Bytes -410.8 KiB -0.089%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 15, 2024

2024-07-15 14:50:16 UTC Pre-commit check for f724910 has started.
2024-07-15 14:53:22 UTC Build+Tests linux-x86_64-release-asan is running...
🟢 2024-07-15 17:04:18 UTC Build successful.
🔴 2024-07-15 17:08:13 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10926 10338 0 85 323 180

🟢 2024-07-15 17:08:59 UTC ydbd size 5.2 GiB changed* by +5.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: ab051d7 merge: f724910 diff diff %
ydbd size 5 567 530 472 Bytes 5 567 536 328 Bytes +5.7 KiB +0.000%
ydbd stripped size 1 199 874 160 Bytes 1 199 874 096 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants