Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue to emit resolved timestamps after merge #6594

Merged

Conversation

CyberROFL
Copy link
Member

@CyberROFL CyberROFL commented Jul 11, 2024

Changelog entry

Continue to emit resolved timestamp after table merge.

Changelog category

  • Bugfix

Additional information

...

@CyberROFL CyberROFL linked an issue Jul 11, 2024 that may be closed by this pull request
@CyberROFL CyberROFL self-assigned this Jul 11, 2024
@CyberROFL CyberROFL requested a review from dcherednik July 11, 2024 22:14
@CyberROFL CyberROFL changed the title Continue to emit resolved timestamp after merge Continue to emit resolved timestamps after merge Jul 11, 2024
Copy link

github-actions bot commented Jul 11, 2024

2024-07-11 22:17:04 UTC Pre-commit check for a988bf6 has started.
2024-07-11 22:19:45 UTC Build+Tests linux-x86_64-release-asan is running...
🟢 2024-07-12 00:20:56 UTC Build successful.
🔴 2024-07-12 00:23:52 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9573 8988 0 81 323 181

🟢 2024-07-12 00:24:40 UTC ydbd size 5.2 GiB changed* by +1.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 3591182 merge: a988bf6 diff diff %
ydbd size 5 609 028 376 Bytes 5 609 030 120 Bytes +1.7 KiB +0.000%
ydbd stripped size 1 207 403 376 Bytes 1 207 403 248 Bytes -128 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 11, 2024

2024-07-11 22:17:05 UTC Pre-commit check for a988bf6 has started.
2024-07-11 22:19:48 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🟢 2024-07-11 23:57:04 UTC Build successful.
🔴 2024-07-12 00:00:45 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13849 12520 0 3 1309 17

🟢 2024-07-12 00:01:24 UTC ydbd size 8.1 GiB changed* by +8.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 3591182 merge: a988bf6 diff diff %
ydbd size 8 719 366 072 Bytes 8 719 374 840 Bytes +8.6 KiB +0.000%
ydbd stripped size 475 747 120 Bytes 475 751 088 Bytes +3.9 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 11, 2024

2024-07-11 22:17:24 UTC Pre-commit check for a988bf6 has started.
2024-07-11 22:20:07 UTC Build+Tests linux-x86_64-release-clang14 is running...
🟢 2024-07-11 22:51:24 UTC Build successful.

@CyberROFL CyberROFL marked this pull request as ready for review July 11, 2024 22:18
@CyberROFL CyberROFL requested a review from a team as a code owner July 11, 2024 22:18
@CyberROFL CyberROFL requested a review from nshestakov July 11, 2024 22:18
@CyberROFL CyberROFL enabled auto-merge (squash) July 12, 2024 09:28
@CyberROFL CyberROFL merged commit f8e93d3 into ydb-platform:main Jul 12, 2024
13 of 20 checks passed
@CyberROFL CyberROFL deleted the resolved-timestamps-after-merge branch July 12, 2024 10:00
CyberROFL added a commit to CyberROFL/ydb that referenced this pull request Jul 12, 2024
CyberROFL added a commit to CyberROFL/ydb that referenced this pull request Jul 12, 2024
CyberROFL added a commit to CyberROFL/ydb that referenced this pull request Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CDC topics whats heartbeat from splitted datashard
2 participants