Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BTreeIndex Bugfix load indexes in scan #657

Conversation

kunga
Copy link
Member

@kunga kunga commented Dec 21, 2023

PrepareBoots может использовать LoadedParts, и на основе них создавать итераторы Boots, поэтому нужно загружать индексы по ним

Copy link

github-actions bot commented Dec 21, 2023

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 35177af.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
59394 50204 0 23 9133 34

🔴 linux-x86_64-release-asan: some tests FAILED for commit 35177af.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15611 15472 0 32 76 31

@kunga kunga requested a review from CyberROFL December 21, 2023 20:20
Copy link
Member

@CyberROFL CyberROFL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А тест будет?

@kunga
Copy link
Member Author

kunga commented Dec 22, 2023

А тест будет?

А тест и упал, только с включённой в протобуфе фичей https://a.yandex-team.ru/review/5062012/details?checkId=72900000008305&dialogId=CiCard&filter=resultType%28RT_TEST_MEDIUM%29%3BsuiteCategory%28CATEGORY_CHANGED%29&iterationType=FULL&number=0&openedItems=16519666930762313687%3ART_TEST_SUITE_MEDIUM&snippetViewMode=word-wrap&status=STATUS_FAILED

Как-то удобно мы не умеем сейчас с двумя вариантами все тесты гонять, поэтому пока стратегия включил -> поправил тест -> выключил обратно

@kunga kunga requested a review from CyberROFL December 22, 2023 09:59
@kunga kunga merged commit 1459018 into ydb-platform:main Dec 22, 2023
2 of 4 checks passed
kunga added a commit to kunga/ydb that referenced this pull request Dec 22, 2023
marsaly79 pushed a commit to marsaly79/ydb that referenced this pull request Dec 22, 2023
@jepett0 jepett0 mentioned this pull request Dec 28, 2023
This was referenced Dec 29, 2023
Closed
This was referenced Jan 11, 2024
@kunga kunga changed the title KIKIMR-19139 Bugfix load indexes BTreeIndex Bugfix load indexes Feb 2, 2024
@kunga kunga changed the title BTreeIndex Bugfix load indexes BTreeIndex Bugfix load indexes in scan Feb 2, 2024
@kunga kunga linked an issue Feb 2, 2024 that may be closed by this pull request
61 tasks
@kunga kunga mentioned this pull request Feb 2, 2024
61 tasks
@kunga kunga removed a link to an issue Feb 2, 2024
61 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants